-
Notifications
You must be signed in to change notification settings - Fork 1.6k
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monitoring idea: Can we support Zipkin or Jaeger? #495
Comments
@tungphuong Ocelot doesnt support zipkin at the moment, you could probably inject middleware or use delegating handlers to add this to Ocelot. I will leave this issue open and look into if we could provide easy integration with zipkin or jaeger. |
Thanks, I am trying to do like that with delegating handlers. Could you please drop me some sample code? I will try |
@TomPallister I know you are ready to support Butterfly. But it is still in preview. So, it is difficult to use for production. So, I suggest we should support Jaeger. |
Butterfly should be replace with skywalking-netcore https://github.com/OpenSkywalking/skywalking-netcore, This is docs https://github.com/apache/incubator-skywalking/tree/master/docs |
OK cool, If anyone wants to pick this work up please feel free to do so! |
started looking at this, I'm going to start breaking the dependencies like butterfly out into there own Ocelot.xxx packages e.g. the first one will be Ocelot.Butterfly. I will have some kind of interface that all the tracing libraries can sustain. This is my general idea and I will see if it works before pushing new versions etc :) |
@geffzhang from looking at Skywalking docs I dont think that you would need to do an Ocelot integration? I will see how it works. |
@TomPallister It was NET Core Probe。http://www.cnblogs.com/liuhaoyang/p/skywalking-dotnet-v02-release.html |
@TomPallister Do you have plan to support Jeager? |
@tungphuong yes in the future, it isn't something I'm working on at the moment. I need to finish #529 before I do this work because I cannot bring more dependencies into Ocelot. Users must be able to pick their dependencies more specifically. |
@TomPallister many thanks, I am waiting for this feature. |
No worries, while you are waiting you might be able to implement for your use case using DelegatingHandlers feature in Ocelot but im not 100% sure. |
I'm currently looking in to add OpenTracing support to Ocelot. Is there anyone else doing this too? |
Currently, I am using "OpenTelemetry" in my project. It is quite good; I will update link then |
support jaeger and zipkin. |
With the Open Tracing support I added you can use Jaeger, Zipkin or any other tracing tool as long as it has a .Net client with the Open Tracing interfaces. @TomPallister maybe it's time to close this one now? |
@TomPallister should this be closed ? As per @kjellegafvelin open tracing supports jaeger. Pls update. |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
HI,
About tracing feature, can we integrate to zipkin or jaeger? Becase Butterfly is still preview version, we cannot use it for production.
Thanks,
The text was updated successfully, but these errors were encountered: