Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring idea: Can we support Zipkin or Jaeger? #495

Closed
tungphuong opened this issue Jul 24, 2018 · 17 comments
Closed

Monitoring idea: Can we support Zipkin or Jaeger? #495

tungphuong opened this issue Jul 24, 2018 · 17 comments
Labels
feature A new feature good first issue Should be pretty easy to do help wanted Not actively being worked on. If you plan to contribute, please drop a note. medium effort Likely a few days of development effort

Comments

@tungphuong
Copy link

HI,

About tracing feature, can we integrate to zipkin or jaeger? Becase Butterfly is still preview version, we cannot use it for production.

Thanks,

@TomPallister
Copy link
Member

@tungphuong Ocelot doesnt support zipkin at the moment, you could probably inject middleware or use delegating handlers to add this to Ocelot. I will leave this issue open and look into if we could provide easy integration with zipkin or jaeger.

@TomPallister TomPallister added feature A new feature help wanted Not actively being worked on. If you plan to contribute, please drop a note. good first issue Should be pretty easy to do medium effort Likely a few days of development effort labels Jul 25, 2018
@tungphuong
Copy link
Author

Thanks, I am trying to do like that with delegating handlers. Could you please drop me some sample code? I will try

@tungphuong
Copy link
Author

@TomPallister I know you are ready to support Butterfly. But it is still in preview. So, it is difficult to use for production. So, I suggest we should support Jaeger.

@geffzhang
Copy link
Contributor

Butterfly should be replace with skywalking-netcore https://github.com/OpenSkywalking/skywalking-netcore, This is docs https://github.com/apache/incubator-skywalking/tree/master/docs

@TomPallister
Copy link
Member

OK cool, If anyone wants to pick this work up please feel free to do so!

@TomPallister
Copy link
Member

TomPallister commented Jul 31, 2018

started looking at this, I'm going to start breaking the dependencies like butterfly out into there own Ocelot.xxx packages e.g. the first one will be Ocelot.Butterfly. I will have some kind of interface that all the tracing libraries can sustain. This is my general idea and I will see if it works before pushing new versions etc :)

@TomPallister
Copy link
Member

@geffzhang from looking at Skywalking docs I dont think that you would need to do an Ocelot integration? I will see how it works.

@geffzhang
Copy link
Contributor

geffzhang commented Aug 3, 2018

@TomPallister It was NET Core Probe。http://www.cnblogs.com/liuhaoyang/p/skywalking-dotnet-v02-release.html
Now we can remove butterfly.

@tungphuong
Copy link
Author

@TomPallister Do you have plan to support Jeager?

@TomPallister
Copy link
Member

@tungphuong yes in the future, it isn't something I'm working on at the moment. I need to finish #529 before I do this work because I cannot bring more dependencies into Ocelot. Users must be able to pick their dependencies more specifically.

@tungphuong
Copy link
Author

@TomPallister many thanks, I am waiting for this feature.

@TomPallister
Copy link
Member

No worries, while you are waiting you might be able to implement for your use case using DelegatingHandlers feature in Ocelot but im not 100% sure.

@kjellegafvelin
Copy link

I'm currently looking in to add OpenTracing support to Ocelot. Is there anyone else doing this too?

@tungphuong
Copy link
Author

Currently, I am using "OpenTelemetry" in my project. It is quite good; I will update link then

@EngRajabi
Copy link
Contributor

support jaeger and zipkin.
These two pamphlets are the best tools

@kjellegafvelin
Copy link

kjellegafvelin commented Jun 1, 2020

With the Open Tracing support I added you can use Jaeger, Zipkin or any other tracing tool as long as it has a .Net client with the Open Tracing interfaces.

@TomPallister maybe it's time to close this one now?

@kaarthickraman
Copy link

@TomPallister should this be closed ? As per @kjellegafvelin open tracing supports jaeger. Pls update.

@raman-m raman-m changed the title Monitoring - can we support zipkin or jaeger? Monitoring idea: Can we support Zipkin or Jaeger? Nov 29, 2023
@ThreeMammals ThreeMammals locked and limited conversation to collaborators Nov 29, 2023
@raman-m raman-m converted this issue into discussion #1820 Nov 29, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
feature A new feature good first issue Should be pretty easy to do help wanted Not actively being worked on. If you plan to contribute, please drop a note. medium effort Likely a few days of development effort
Projects
None yet
Development

No branches or pull requests

6 participants