Exception mapper naming #1211
Merged
Exception mapper naming #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Anthony! Could you resolve merge conflicts please? |
added 2 commits
July 26, 2023 20:17
"Exeption" -> "Exception"
raman-m
force-pushed
the
exception-mapper-naming
branch
from
5293dc5
to
a128146
Compare
… characters: {should_*}
Fix name violation
raman-m
approved these changes
Jul 26, 2023
raman-m
added
bug
|
Anthony, Merge conflicts have been resolved! Finally, I've approved the PR! Thanks for your eagle eye! 🦅 👁️ Could you add me as collaborator to your forked repo please? I will create develop branch and make it default. |
|
@AnthonySteele
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / New Feature #
Proposed Changes
Fix typo in class and file name, and same for test
Exeption->Exception