Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed logger message typos in the OutputCacheMiddleware class #1315

Merged
merged 5 commits into from
Sep 22, 2023
Merged

Fixed logger message typos in the OutputCacheMiddleware class #1315

merged 5 commits into from
Sep 22, 2023

Conversation

thiagoloureiro
Copy link
Contributor

@thiagoloureiro thiagoloureiro commented Aug 17, 2020 •
edited by raman-m

Proposed Changes

Fixed typos in the log when caching:

@thiagoloureiro
Copy link
Contributor Author

@TomPallister this is a simple one, can you approve pls?

@raman-m raman-m changed the base branch from master to develop June 8, 2023 11:10
@raman-m raman-m self-requested a review June 8, 2023 11:15
@raman-m raman-m changed the title fixed typo in log Fixed logger message typo in the OutputCacheMiddleware class Jun 8, 2023
@raman-m raman-m changed the title Fixed logger message typo in the OutputCacheMiddleware class Fixed logger message typos in the OutputCacheMiddleware class Jun 8, 2023
@raman-m
Copy link
Member

raman-m commented Jun 8, 2023

@thiagoloureiro
Hi Thiago!

I've made some improvements in this PR and committed them.
The PR has been approved by me!

I see that there is no activity from your side for more than one year.
And your last commits in develop branch were merged in 2019...
Do you have an intention to be the member of Ocelot team further?

@raman-m raman-m added bug Identified as a potential bug small effort Likely less than a day of development effort. accepted Bug or feature would be accepted as a PR or is being worked on in progress Someone is working on the issue. Could be someone on the team or off. documentation Needs a documentation update labels Jun 8, 2023
@raman-m
Copy link
Member

raman-m commented Jun 8, 2023

@TomPallister Could you review and merge the PR please?
I am still not able to merge PRs...

@thiagoloureiro
Copy link
Contributor Author

@thiagoloureiro

Hi Thiago!

I've made some improvements in this PR and committed them.

The PR has been approved by me!

I see that there is no activity from your side for more than one year.

And your last commits in develop branch were merged in 2019...

Do you have an intention to be the member of Ocelot team further?

Why those questions? We all have full time jobs and we contribute when we can. I don't get your comments asking if I still want to be part of it..

@raman-m raman-m reopened this Jul 6, 2023
@raman-m raman-m removed small effort Likely less than a day of development effort. in progress Someone is working on the issue. Could be someone on the team or off. labels Jul 6, 2023
@raman-m raman-m self-assigned this Jul 6, 2023
@raman-m raman-m merged commit e6081ce into develop Sep 22, 2023
2 checks passed
@raman-m raman-m deleted the fix_typo_in_log branch September 22, 2023 19:15
@raman-m raman-m mentioned this pull request Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndybSe AndybSe AndybSe approved these changes

@raman-m raman-m raman-m approved these changes

@TomPallister TomPallister Awaiting requested review from TomPallister

@binarymash binarymash Awaiting requested review from binarymash

@geffzhang geffzhang Awaiting requested review from geffzhang

Assignees

@raman-m raman-m

Labels
accepted Bug or feature would be accepted as a PR or is being worked on bug Identified as a potential bug documentation Needs a documentation update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thiagoloureiro @raman-m @AndybSe