-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1057 #1068 Add service discovery logs #1366
Merged
raman-m
merged 7 commits into
ThreeMammals:develop
from
jlukawska:add-service-discovery-logs
Sep 23, 2023
Merged
#1057 #1068 Add service discovery logs #1366
raman-m
merged 7 commits into
ThreeMammals:develop
from
jlukawska:add-service-discovery-logs
Sep 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raman-m
force-pushed
the
add-service-discovery-logs
branch
from
July 15, 2023 14:43
939349f
to
0727c97
Compare
Thank you for the PR! |
raman-m
force-pushed
the
add-service-discovery-logs
branch
from
August 10, 2023 18:27
3241b1e
to
89b4439
Compare
The feature branch has been rebased onto ThreeMammals:develop! |
raman-m
added
proposal
Proposal for a new functionality in Ocelot
needs feedback
Issue is waiting on feedback before acceptance
labels
Aug 10, 2023
wast
previously approved these changes
Aug 10, 2023
RaynaldM
previously approved these changes
Aug 11, 2023
raman-m
previously approved these changes
Aug 18, 2023
raman-m
added
accepted
Bug or feature would be accepted as a PR or is being worked on
and removed
needs feedback
Issue is waiting on feedback before acceptance
labels
Aug 18, 2023
@TomPallister |
RaynaldM
previously approved these changes
Aug 21, 2023
This was
linked to
issues
Sep 21, 2023
raman-m
changed the title
Add service discovery logs
#1057 #1068 Add service discovery logs
Sep 21, 2023
raman-m
approved these changes
Sep 21, 2023
RaynaldM
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accepted
Bug or feature would be accepted as a PR or is being worked on
proposal
Proposal for a new functionality in Ocelot
Service Discovery
Ocelot feature: Service Discovery
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1057 #1068
Proposed Changes
The issues regarding communication with Consul are quite common. Currently the Ocelot logs don't show the basic information about this communication. I think it could be very useful for debugging purposes.