Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1057 #1068 Add service discovery logs #1366

Merged
merged 7 commits into from
Sep 23, 2023

Conversation

jlukawska
Copy link
Contributor

@jlukawska jlukawska commented Nov 9, 2020

Closes #1057 #1068

Proposed Changes

The issues regarding communication with Consul are quite common. Currently the Ocelot logs don't show the basic information about this communication. I think it could be very useful for debugging purposes.

EngRajabi

This comment was marked as spam.

@raman-m raman-m changed the base branch from master to develop July 15, 2023 14:42
@raman-m raman-m force-pushed the add-service-discovery-logs branch from 939349f to 0727c97 Compare July 15, 2023 14:43
@raman-m
Copy link
Member

raman-m commented Jul 15, 2023

Thank you for the PR!

@raman-m raman-m added the Service Discovery Ocelot feature: Service Discovery label Aug 10, 2023
@raman-m
Copy link
Member

raman-m commented Aug 10, 2023

The feature branch has been rebased onto ThreeMammals:develop!
Welcome to code review!

@raman-m raman-m added proposal Proposal for a new functionality in Ocelot needs feedback Issue is waiting on feedback before acceptance labels Aug 10, 2023
wast
wast previously approved these changes Aug 10, 2023
RaynaldM
RaynaldM previously approved these changes Aug 11, 2023
@raman-m raman-m dismissed stale reviews from RaynaldM and wast via 5a5f1c0 August 18, 2023 11:02
raman-m
raman-m previously approved these changes Aug 18, 2023
src/Ocelot.Provider.Consul/Consul.cs Outdated Show resolved Hide resolved
src/Ocelot.Provider.Consul/Consul.cs Outdated Show resolved Hide resolved
@raman-m raman-m added accepted Bug or feature would be accepted as a PR or is being worked on and removed needs feedback Issue is waiting on feedback before acceptance labels Aug 18, 2023
@raman-m raman-m requested review from TomPallister and removed request for EngRajabi August 18, 2023 11:13
@raman-m
Copy link
Member

raman-m commented Aug 18, 2023

@TomPallister
This PR is ready to merge.

RaynaldM
RaynaldM previously approved these changes Aug 21, 2023
@raman-m raman-m changed the title Add service discovery logs #1057 #1068 Add service discovery logs Sep 21, 2023
@raman-m raman-m dismissed stale reviews from RaynaldM and themself via e3b6c92 September 21, 2023 20:52
@raman-m raman-m merged commit b27761f into ThreeMammals:develop Sep 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Bug or feature would be accepted as a PR or is being worked on proposal Proposal for a new functionality in Ocelot Service Discovery Ocelot feature: Service Discovery
Projects
None yet
5 participants