#1700 Create custom Ocelot config file when instantiating steps during parallel execution #1703
Conversation
…Finally deleting the newly created config file when disposing the Step instance.
|
Wow! Cool! Just commit a small change of Ocelot core, not tests, and the 2nd commit should be revert commit of previous one. Good plan? |
|
@raman-m no way, that's really funny ;-) 6 out of 10... I can't reproduce that on my machine |
|
@raman-m Ok, a bit better now, 9 out of 11... |
…le.WriteAllText will overwrite the file.
This reverts commit 9fac778.
raman-m
force-pushed
the
bug/1700-unstable-test-should-reload-config-on-change
branch
from
1c97c39
to
b17db75
Compare
@raman-m No it wasn't, but the random port finder code doesn't seem to be thread safe, since the concurrentbag would allow identical values to be stored and the method can be accessed by several threads concurrently |
…t_routes from 1000 ms to 1500 ms
https://github.com/ggnaegi/Ocelot into bug/1700-unstable-test-should-reload-config-on-change
|
@raman-m imho ok to merge |
raman-m
added
accepted
|
@ggnaegi Congrats! |
Fixes #1700
When instantiating steps, creating a custom ocelot config file name. Finally deleting the newly created config file when disposing the
Stepinstance.Proposed Changes
Stepis instantiated for each fact/theory, we need to ensure that the corresponding fact/theory only uses its own ocelot configuration file, without interfering with the configuration files of other facts and theories.