-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1527 #1529] Breaking change to the class renaming of Kube
service discovery provider
#1954
Conversation
@ZisisTsatsas Hi Zisis! You are right, the docs were not updated. @ggnaegi Do you agree using old types |
@ZisisTsatsas Could you help me with resolving this breaking change plz? |
Kube
service discovery provider
Kube
service discovery providerKube
service discovery provider
The `Type` field for the kubernetes example is outdated
The root cause of the problem:
of these block of code: Ocelot/src/Ocelot/ServiceDiscovery/ServiceDiscoveryProviderFactory.cs Lines 55 to 63 in c9510b1
where
Finally, in this line of code we have
→ if ("KubernetesServiceDiscoveryProvider".ToLower() == "Kube".ToLower()) which is false always!This is the bug and the breaking change ❗ |
Hi @ZisisTsatsas !
So, these bugs will be closed officially by your PR 😉 @ggnaegi FYI |
Kube
service discovery providerKube
service discovery provider
Kube
service discovery providerKube
service discovery provider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZisisTsatsas |
I will be using it! Thanks for the quick udpate |
The
Type
field for the Kubernetes example is outdated in the docsUpdate by Maintainer on Feb 10, 2024 👉
Fixes #1527 #1529