Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cove: templates: Copy in and change lib-cove-web input template #108

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

michaelwood
Copy link
Member

We're needing to deviate from lib-cove-web provided template to change the button copy which is causing confusion between checking the data and submitting the data. Further changes away from the default layout are planned so this is partly a stop-gap solution.

Fixes: #102

We're needing to deviate from lib-cove-web provided template to change
the button copy which is causing confusion between checking the data and
submitting the data. Further changes away from the default layout are
planned so this is partly a stop-gap solution.

Fixes: #102
@michaelwood michaelwood requested a review from R2ZER0 May 31, 2024 14:56
@michaelwood
Copy link
Member Author

image

Copy link

@mariongalley mariongalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the screenshot I'm happy with this

Copy link
Contributor

@codemacabre codemacabre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michaelwood michaelwood merged commit df032d9 into main Jun 3, 2024
4 checks passed
@michaelwood michaelwood deleted the mw/submit-to-check branch June 3, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename 'Check your data' buttons to avoid confusion
3 participants