Extensions mechanism #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WIP for #97 |
This adds functionality to the Schema class to resolve a 360Giving json schema extension into the standard extension. The steps involved in this are: 1) unflatten the input data (if needed) using the vanilla schema 2) Replace the external reference in the package schema to a downloaded version of the grants schema 3) If an extension is detected merge in the extension 4) Re-unflatten the data with the new resolved schema file 5) Run common checks as normal Process codelists functionality has been extended to allow codelists to be loaded that are referenced by the extension.
This test doesn't appear to do anything
michaelwood
force-pushed
the
mw/extensions_mech
branch
from
1824e9e
to
f8dfd54
Compare
This is now merged so no longer needs to point to a branch
This is now failing due to a quirk in the way in which null is interpreted when not in an embedded codelist. The lack of message here is consistent with other codelists. This behaviour changed as a result of using a local version of the grant standard and downloaded codelist when "resolving" the standard. ThreeSixtyGiving/standard#379
michaelwood
force-pushed
the
mw/extensions_mech
branch
from
3339d46
to
af55da5
Compare
R2ZER0
reviewed
Apr 2, 2024
R2ZER0
reviewed
Apr 2, 2024
R2ZER0
reviewed
Apr 2, 2024
R2ZER0
previously approved these changes
Apr 2, 2024
michaelwood
force-pushed
the
mw/extensions_mech
branch
from
37aaa51
to
bb8f172
Compare
Avoid a potential clash of schema data vs grant data if file names were the same. Also remove redundant comment about 1.4 release. This has happened now.
michaelwood
force-pushed
the
mw/extensions_mech
branch
from
bb8f172
to
5936012
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.