Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using inline styles (because CSP) #56

Open
csuhta opened this issue Sep 22, 2016 · 2 comments
Open

Stop using inline styles (because CSP) #56

csuhta opened this issue Sep 22, 2016 · 2 comments
Assignees

Comments

@csuhta
Copy link
Collaborator

csuhta commented Sep 22, 2016

Some Tolaria features (the login form, a few of the JS form elements) use inline CSS styles, which preclude you from using the admin with a Content-Security-Policy unless you set the undesirable 'unsafe-inline' directive.

Refactor the UI elements so that they use CSS classes to manage their appearance, rather than inline styles. As a warning: we also have to move away from jQuery's hide() and show() because those use inline styles.

@csuhta csuhta self-assigned this Sep 22, 2016
@defbyte
Copy link
Collaborator

defbyte commented Sep 22, 2016

Will there be backwards incompatible changes introduced? For example, I know of a project where we customized the Markdown editor, adding new toolbar buttons and stuff. Just wondering, thanks!

@csuhta
Copy link
Collaborator Author

csuhta commented Sep 22, 2016

@defbyte Very likely. This will probably be part of Tolaria 3.0 or higher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants