-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gunicorn requirements bump #62
Conversation
Oh hmm this got a weird commit in it, let me futz around and make it clean again |
1a14a8b
to
15119c5
Compare
There we go, all better. |
15119c5
to
093e9dc
Compare
9559be7
to
4598793
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the CI, thanks a lot.
Accept 3.7 removal Co-Authored-By: aawilson <aawilson.iz.ssha@gmail.com>
No problem, done. |
b7557d1
to
875182c
Compare
Well, "done", I accepted the suggested fix but it somehow got formatted very strangely, but now build is in progress. |
I have already bump gevent to latest at #63 , thanks. And you can use |
Thanks for the tox expertise, it took forever for it to finally execute the tasks and error out and by then it was the weekend. May I suggest that the "<1.5" specifier be removed until a report comes in that a particular major breaks gunicorn_thrift? When I originally put the "<1.3" there I had the same thought of future-proofed requirements, but that's exactly what has led to this now, and I've come around to thinking that packages should err on permissive, since it's much easier for a user of the package to specify a version restriction in their local requirements.txt than it is to bypass the package-specified list, and because it seems like specific incompatibilities are most sensibly dealt with on a case-by-case basis rather than preemptively excluded. |
Yep, I think "<1.5" is not necessary either. I checked the change list of Gevent, and the maintainers of Gevent think that the number behind the first dot is a small version release and it takes nothing breaking down about compatibility. |
Waiting on anything in particular for the pypi push/version bump? Just need to know when I can move my requirements.txt to its normal version specifier rather than the git-based one, is all. |
It has already been bumped to 0.2.23 at Dec 14, 2018 I think. |
Right, which was three months before this pull request. 0.2.23 disallows gevent >= 1.3 (in py3):
|
OK I will bump a new version right now. |
0.2.24 released, thanks. |
🙇 you are a gentleman and a scholar |
You are welcome. |
Allow gevent > 1.3.0 (specifically, in my case, 1.4.0). Passes tox in 3.6, so hopefully the other environments pass after I submit this PR. Let me know if there are any concerns about the version bump, although honestly I was the one who put a limit in in the first place (probably out of misplaced caution) so I doubt there are specific fears.