Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gunicorn requirements bump #62

Closed
wants to merge 4 commits into from

Conversation

aawilson
Copy link
Contributor

Allow gevent > 1.3.0 (specifically, in my case, 1.4.0). Passes tox in 3.6, so hopefully the other environments pass after I submit this PR. Let me know if there are any concerns about the version bump, although honestly I was the one who put a limit in in the first place (probably out of misplaced caution) so I doubt there are specific fears.

@aawilson
Copy link
Contributor Author

Oh hmm this got a weird commit in it, let me futz around and make it clean again

@aawilson
Copy link
Contributor Author

There we go, all better.

.travis.yml Outdated Show resolved Hide resolved
@ethe ethe self-requested a review March 15, 2019 01:41
Copy link
Member

@ethe ethe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI, thanks a lot.

@ethe ethe requested a review from wooparadog March 15, 2019 01:44
Accept 3.7 removal

Co-Authored-By: aawilson <aawilson.iz.ssha@gmail.com>
@aawilson
Copy link
Contributor Author

No problem, done.

@aawilson
Copy link
Contributor Author

Well, "done", I accepted the suggested fix but it somehow got formatted very strangely, but now build is in progress.

@ethe
Copy link
Member

ethe commented Mar 16, 2019

I have already bump gevent to latest at #63 , thanks. And you can use pip install git+https://github.com/Thriftpy/gunicorn_thrift.git@master to get latest version temporarily, I will push it to PyPi in the future.

@ethe ethe closed this Mar 16, 2019
@aawilson
Copy link
Contributor Author

Thanks for the tox expertise, it took forever for it to finally execute the tasks and error out and by then it was the weekend. May I suggest that the "<1.5" specifier be removed until a report comes in that a particular major breaks gunicorn_thrift? When I originally put the "<1.3" there I had the same thought of future-proofed requirements, but that's exactly what has led to this now, and I've come around to thinking that packages should err on permissive, since it's much easier for a user of the package to specify a version restriction in their local requirements.txt than it is to bypass the package-specified list, and because it seems like specific incompatibilities are most sensibly dealt with on a case-by-case basis rather than preemptively excluded.

@aawilson aawilson deleted the gunicorn_requirements_bump branch March 18, 2019 20:25
@aawilson aawilson restored the gunicorn_requirements_bump branch March 18, 2019 23:31
@ethe
Copy link
Member

ethe commented Mar 19, 2019

Yep, I think "<1.5" is not necessary either. I checked the change list of Gevent, and the maintainers of Gevent think that the number behind the first dot is a small version release and it takes nothing breaking down about compatibility.

@aawilson
Copy link
Contributor Author

aawilson commented May 9, 2019

Waiting on anything in particular for the pypi push/version bump? Just need to know when I can move my requirements.txt to its normal version specifier rather than the git-based one, is all.

@ethe
Copy link
Member

ethe commented May 13, 2019

It has already been bumped to 0.2.23 at Dec 14, 2018 I think.

@aawilson
Copy link
Contributor Author

Right, which was three months before this pull request. 0.2.23 disallows gevent >= 1.3 (in py3):

# gunicorn_thrift-0.2.23/requirements_py3.txt
setproctitle==1.1.10
gevent>=1.2,<1.3
gunicorn>=19.4.0
thriftpy2>=0.4.0

@ethe
Copy link
Member

ethe commented May 14, 2019

OK I will bump a new version right now.

@ethe
Copy link
Member

ethe commented May 14, 2019

0.2.24 released, thanks.

@aawilson
Copy link
Contributor Author

🙇 you are a gentleman and a scholar

@ethe
Copy link
Member

ethe commented May 15, 2019

You are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants