This repository has been archived by the owner on Dec 10, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 288
Fix a small bug on default_spec #145
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,6 +69,7 @@ class TMessageType(object): | |
|
||
|
||
class TPayloadMeta(type): | ||
|
||
def __new__(cls, name, bases, attrs): | ||
if "default_spec" in attrs: | ||
attrs["__init__"] = init_func_generator(attrs.pop("default_spec")) | ||
|
@@ -79,12 +80,13 @@ def gen_init(cls, thrift_spec=None, default_spec=None): | |
if thrift_spec is not None: | ||
cls.thrift_spec = thrift_spec | ||
|
||
if "default_spec" is not None: | ||
if default_spec is not None: | ||
cls.__init__ = init_func_generator(default_spec) | ||
return cls | ||
|
||
|
||
class TPayload(with_metaclass(TPayloadMeta, object)): | ||
|
||
def read(self, iprot): | ||
iprot.read_struct(self) | ||
|
||
|
@@ -110,6 +112,7 @@ def __ne__(self, other): | |
|
||
|
||
class TClient(object): | ||
|
||
def __init__(self, service, iprot, oprot=None): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is the change ok here? @maralla some parameters I dont really know what its types will be and In line 173 also There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's better to use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I will |
||
self._service = service | ||
self._iprot = self._oprot = iprot | ||
|
@@ -167,7 +170,7 @@ def _recv(self, _api): | |
|
||
# check throws | ||
for k, v in result.__dict__.items(): | ||
if k != "success" and v is not None: | ||
if k != "success" and v: | ||
raise v | ||
|
||
# no throws & not void api | ||
|
@@ -289,6 +292,7 @@ def call(): | |
|
||
|
||
class TProcessorFactory(object): | ||
|
||
def __init__(self, processor_class, *args, **kwargs): | ||
self.args = args | ||
self.kwargs = kwargs | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont understand why that I change
x is not None
tox
cannot pass the travis-ci @maralla