Skip to content
This repository has been archived by the owner on Dec 10, 2018. It is now read-only.

Fix a small bug on default_spec #145

Merged
merged 1 commit into from
Jul 10, 2015
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions thriftpy/thrift.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ class TMessageType(object):


class TPayloadMeta(type):

def __new__(cls, name, bases, attrs):
if "default_spec" in attrs:
attrs["__init__"] = init_func_generator(attrs.pop("default_spec"))
Expand All @@ -79,12 +80,13 @@ def gen_init(cls, thrift_spec=None, default_spec=None):
if thrift_spec is not None:
cls.thrift_spec = thrift_spec

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont understand why that I change x is not None to x cannot pass the travis-ci @maralla

if "default_spec" is not None:
if default_spec is not None:
cls.__init__ = init_func_generator(default_spec)
return cls


class TPayload(with_metaclass(TPayloadMeta, object)):

def read(self, iprot):
iprot.read_struct(self)

Expand All @@ -110,6 +112,7 @@ def __ne__(self, other):


class TClient(object):

def __init__(self, service, iprot, oprot=None):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the change ok here? @maralla some parameters I dont really know what its types will be and In line 173 also

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better to use is not None

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will

self._service = service
self._iprot = self._oprot = iprot
Expand Down Expand Up @@ -167,7 +170,7 @@ def _recv(self, _api):

# check throws
for k, v in result.__dict__.items():
if k != "success" and v is not None:
if k != "success" and v:
raise v

# no throws & not void api
Expand Down Expand Up @@ -289,6 +292,7 @@ def call():


class TProcessorFactory(object):

def __init__(self, processor_class, *args, **kwargs):
self.args = args
self.kwargs = kwargs
Expand Down