Skip to content
This repository has been archived by the owner on Dec 10, 2018. It is now read-only.

Reset self.sock if connection fails #298

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Reset self.sock if connection fails #298

wants to merge 4 commits into from

Commits on Jun 19, 2017

  1. Reset self.sock if connection fails 

    If we don't reset `self.sock` on connection error, then `my_socket.is_open()` will still return `True` after `TTransportException` is thrown.
    @ecederstrand
    ecederstrand committed Jun 19, 2017
    Configuration menu
    Copy the full SHA
    4a3385b View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2017

  1. Always set self.sock=None on close() 

    Otherwise, `self.is_open()` may still return `True` after `close()`
    @ecederstrand
    ecederstrand committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    c85cb5d View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2017

  1. Add tests for is_open() on failure

    Erik Cederstrand authored and Erik Cederstrand committed Jul 31, 2017
    Configuration menu
    Copy the full SHA
    ec73667 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2017

  1. Remove timeout args as suggested by @wbolster

    Erik Cederstrand authored and Erik Cederstrand committed Aug 1, 2017
    Configuration menu
    Copy the full SHA
    8e047cc View commit details
    Browse the repository at this point in the history