You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It looks like fill_incomplete_ttype should deal with declaration order, but misses the list field. I would also expect serializing or deserializing incomplete types to fail instead of silently substituting 'None', since this makes bugs hard to debug.
The text was updated successfully, but these errors were encountered:
If you have a field with a type like
list<T>
,T
must already have been declared, or the field will be serialized wrong.How to reproduce:
In
tests/container.thrift
, move ListStruct to the top of the file, before ListItem,Run the tests and
test_container.py
will fail:It looks like
fill_incomplete_ttype
should deal with declaration order, but misses the list field. I would also expect serializing or deserializing incomplete types to fail instead of silently substituting 'None', since this makes bugs hard to debug.The text was updated successfully, but these errors were encountered: