Fix the path issue caused by #148 #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
==========================================
+ Coverage 83.33% 83.35% +0.01%
==========================================
Files 43 43
Lines 3931 3935 +4
==========================================
+ Hits 3276 3280 +4
Misses 655 655
Continue to review full report at Codecov.
|
aisk
force-pushed
the
fix-path
branch
4 times, most recently
from
cc95379
to
86cea2c
Compare
|
Looking forward to a new release that includes this fix! |
|
I will release it as soon as possible, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bofore #148,
pathinmake_client/client_contextshould have/prefix. After #148 been merged,pathmust have no/prefix, this will break exists codes using it, and as @dmulter said,pathshould have/.In this PR, thriftpy2 will support these two usecases both, and the no
/prefix is malformed but I think we should not break exists code again.