Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue that py3.4 cannot use pytest due to latest attr dropping support. #175

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

truebit
Copy link
Contributor

@truebit truebit commented May 17, 2021

try to fix #174

@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #175 (220aabf) into master (8e218b3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   84.31%   84.31%           
=======================================
  Files          44       44           
  Lines        4164     4164           
=======================================
  Hits         3511     3511           
  Misses        653      653           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e218b3...220aabf. Read the comment docs.

@truebit truebit changed the title fix issue when py3.4 cannot use pytest due to latest attr dropping support. fix issue that py3.4 cannot use pytest due to latest attr dropping support. May 17, 2021
@ethe
Copy link
Member

ethe commented Jan 7, 2022

LGTM, thanks

@ethe ethe merged commit 8755065 into Thriftpy:master Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError: No module named 'typing' on python 3.4 due to attr drop support on >=21.1.0
2 participants