Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example with std library module #13

Merged
merged 4 commits into from
Nov 23, 2023

Conversation

mohammed-ali-1
Copy link
Collaborator

@mohammed-ali-1 mohammed-ali-1 commented Nov 21, 2023

This PR adds a slightly more complex fourth example file that shows how a target file can also import a module from the Python standard library.

While working on the PR I encountered the following 2 issues:

  1. vulnerable dependencies which were updated in bc7da59
  2. mypy issue with __ror__ overload of dict which was fixed in cc6e052

Finally, I bump up the version in ccb4234 to 0.2.0.

I'd appreciate a quick lock just to make sure I didn't miss anything.

Copy link
Owner

@ThunderKey ThunderKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ThunderKey ThunderKey merged commit 3d72917 into main Nov 23, 2023
5 checks passed
@ThunderKey ThunderKey deleted the add-example-with-std-library-module branch November 23, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants