Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in Unity 2021.1.13f1 #51

Closed
mnicolas94 opened this issue Aug 17, 2022 · 0 comments
Closed

Error in Unity 2021.1.13f1 #51

mnicolas94 opened this issue Aug 17, 2022 · 0 comments

Comments

@mnicolas94
Copy link
Contributor

mnicolas94 commented Aug 17, 2022 •
edited

Describe the bug
I installed the package in a fresh new project and got these 2 errors:

Library\PackageCache\net.tnrd.serializableinterface@1.11.1\Editor\Utilities\IconUtility.cs(56,37): error CS0117: 'EditorGUIUtility' does not contain a definition for 'GetIconForObject'

Library\PackageCache\net.tnrd.serializableinterface@1.11.1\Editor\Drawers\ReferenceDrawer.cs(223,20): error CS0154: The property or indexer 'SerializedProperty.managedReferenceValue' cannot be used in this context because it lacks the get accessor

I'm using Unity 2021.1.13f1 and both errors are inside a #if UNITY_2021_1_OR_NEWER directive. So, i assume is a version related issue.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new project in Unity 2021.1.13f1
  2. Install this package
  3. See error in console

Expected behavior
Not get the errors

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • Windows

Unity (please complete the following information):

  • 2021.1.13f1

Additional context
Add any other context about the problem here.
mnicolas94 added a commit to mnicolas94/Unity3D-SerializableInterface that referenced this issue Aug 17, 2022
@mnicolas94
fix: fix issue with unity version 2021.1
d81e9df 
issue Thundernerd#51
mnicolas94 added a commit to mnicolas94/Unity3D-SerializableInterface that referenced this issue Aug 17, 2022
@mnicolas94
fix: fix version directive in IconUtility
ffe848c 
issue Thundernerd#51
@mnicolas94 mnicolas94 mentioned this issue Aug 17, 2022
Merged
12 tasks
Thundernerd pushed a commit that referenced this issue Sep 10, 2022
@semantic-release-bot
chore(release): 1.12.1 [skip ci]
a1cfb3c 
### [1.12.1](v1.12.0...v1.12.1) (2022-09-10)

### Bug Fixes

* fix editor drawing of managed classes inside list ([8d66349](8d66349))
* fix issue with unity version 2021.1 ([d81e9df](d81e9df)), closes [#51](#51)
* fix version directive in IconUtility ([ffe848c](ffe848c)), closes [#51](#51)
* make changes requested in code review. Also, fix stop condition in for loop that traverses serialized property's path in SerializedPropertyUtilities.GetValue() function ([191d442](191d442))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Thundernerd @mnicolas94