Skip to content

Commit

Permalink
fix: Remove IE 11 from default browsers for Windows (shaka-project#4272)
Browse files Browse the repository at this point in the history
IE 11 has not been supported since v3.1, so developers following
CONTRIBUTING.md should not see tests fail due to the continued inclusion
of IE. Removed IE from the default list of browsers for Windows. Anybody
who still needs to test against IE can explicitly test via python
build/test.py --browsers IE.

Closes shaka-project#4271
  • Loading branch information
RaymondCheng committed Jun 4, 2022
1 parent 913ee57 commit 490b06c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions AUTHORS
Expand Up @@ -79,3 +79,4 @@ Verizon Digital Media Services <*@verizondigitalmedia.com>
ViacomCBS <*@viacomcbs.com>
Vincent Valot <valot.vince@gmail.com>
Wayne Morgan <wayne.morgan.dev@gmail.com>
Raymond Cheng <raycheng100@gmail.com>
1 change: 1 addition & 0 deletions CONTRIBUTORS
Expand Up @@ -117,3 +117,4 @@ Vignesh Venkatasubramanian <vigneshv@google.com>
Vincent Valot <valot.vince@gmail.com>
Wayne Morgan <wayne.morgan.dev@gmail.com>
Yohann Connell <robinconnell@google.com>
Raymond Cheng <raycheng100@gmail.com>
2 changes: 1 addition & 1 deletion build/test.py
Expand Up @@ -104,7 +104,7 @@ def _GetDefaultBrowsers():
return ['Chrome','Edge','Firefox','Safari']

if shakaBuildHelpers.is_windows() or shakaBuildHelpers.is_cygwin():
return ['Chrome','Edge','Firefox','IE']
return ['Chrome','Edge','Firefox']

raise Error('Unrecognized system: %s' % platform.uname()[0])

Expand Down

0 comments on commit 490b06c

Please sign in to comment.