Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag::read_from_path should return Result<Box<dyn AudioTag + Send + Sync>> #8

Closed
noonebtw opened this issue Nov 14, 2021 · 0 comments · Fixed by #21
Closed

Tag::read_from_path should return Result<Box<dyn AudioTag + Send + Sync>> #8

noonebtw opened this issue Nov 14, 2021 · 0 comments · Fixed by #21

Comments

@noonebtw
Copy link

All the tag types currently are Send and Sync, so it would be useful to also pass this down.
Serial-ATA added a commit to Serial-ATA/audiotags that referenced this issue Aug 1, 2022
@Serial-ATA
Change Tag::read_from_path return type to `Result<Box<dyn AudioTag …
339dcee 
…+ Send + Sync>>`

closes: TianyiShi2001#8
@Serial-ATA Serial-ATA mentioned this issue Aug 1, 2022
Merged
Serial-ATA added a commit to Serial-ATA/audiotags that referenced this issue Aug 1, 2022
@Serial-ATA
Change Tag::read_from_path return type to `Result<Box<dyn AudioTag …
adfcc55 
…+ Send + Sync>>`

closes: TianyiShi2001#8
pinkforest pushed a commit that referenced this issue Aug 2, 2022
@Serial-ATA
Fix remaining issues (#21)
2fa3f6c 
* Remove `unwrap` in `Tag::read_from_path`

closes: #7

* Fix `Id3v2Tag::{*year}` methods

closes: #9

* Fix unused `Result` in `Tag` doc example

* Reorder `FlagTag` and `Mp4Tag` impls to match `AudioTagEdit`

* Change `Tag::read_from_path` return type to `Result<Box<dyn AudioTag + Send + Sync>>`

closes: #8

* Fix doc test

* Fix typos

* Bump versions

* fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix remaining issues Serial-ATA/audiotags
1 participant
@noonebtw