-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All popup windows steal focus from everything when they first appear in patch v2.0.1 #10
Comments
The issue has been identified (under the May 2023 client). The problem in part is coming from the resolution to #9. When the fix for #9 is removed, this issue (focus stealing) no longer occurs. Also, while the OP notes this happens when ingame, this also happens outside of games as well. All windows created by FriendsUI's inner frame (incl. Friends List and friend chat windows) automatically steal focus when they are first created. This is not the correct behavior. Since the code that fixes #9 is present in 8200419 and 8200419 does not have this problem, the only conclusion is that the context surrounding calls to |
The solution to this issue (focus stealing) is co-dependent on reverting the fix to #9 and devising a new fix for #9. This might seem a little tricky, since the Dec 2022 client relies on the fix for #9 or else all chat windows are solid black, so we cannot comprise that. The thorough solution involves hours of time digging through Valve's bastardized JS. Fuck that. SolutionThe fix for #9 changes 8601984's line: In the false path of the ternary, the It's anyone's guess why the So the line is now: Effects of solutionMaking the change noted above, both #9 and this issue are resolved in my tests in both the May 2023 client (my primary baseline for this patch) and the Dec 2022 client, without any concessions or regressions (discovered so far). Hopefully it stays that way. This will quickly be deployed into a hotfix update. |
Patch version 2.0.2 has been released, which resolves this issue as noted above. |
Problem
Notes
I have verified that this occurs in patch v2.0.1, and that it does not occur in patch v1.2.0.
The problem seems to originate from some change(s) Valve made between 8200419 and 8601984.
Obviously the correct behavior is for the Steam overlay to handle the message notification without yanking you out of the game back to your desktop.
The text was updated successfully, but these errors were encountered: