Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Characters section, deaths, non-breaking spaces #97

Closed
3ckdasnk opened this issue Mar 8, 2022 · 7 comments · Fixed by #99 or #100
Closed

Characters section, deaths, non-breaking spaces #97

3ckdasnk opened this issue Mar 8, 2022 · 7 comments · Fixed by #99 or #100
Assignees
Labels
bug Something isn't working

Comments

@3ckdasnk
Copy link

3ckdasnk commented Mar 8, 2022

Im pretty noob at this point, so if its not a bug - sorry.
Well, i rewrite my app to use v3 instead of v2 and after 3 days of using i realized that in every deaths, in every name with "space", instead of normal spaces, there is everywhere non-breaking spaces what literally fucked up everything in my case (for example i cant search for character name, becouse "xxx xxx" its not the same as "xxx\u00a0xxx")
well... i got 10k deaths in my db with that bullshit spaces... i belive that in v2 there are normal spaces, becouse i never had that problem before
the problem is with "reasons" and also with all the names separately at deathlist...
ofc i can fix it by my side while adding everything to db, but im pretty sure it should be changed at api side

@3ckdasnk
Copy link
Author

3ckdasnk commented Mar 9, 2022

Its definitely a bug, becouse in Worlds online list all player names are with normal spaces, but when it comes to characters deaths every name has nbsp (tibia.com in both places using nbsp, in api only in deathlist its not converted to normal space)

@tobiasehlert
Copy link
Member

hi @3ckdasnk,

thanks for reporting, to me it seems to work fine now on dev.tibiadata.com
please verify that it looks good for you there too 😃

@3ckdasnk
Copy link
Author

3ckdasnk commented Mar 10, 2022

@tobiasehlert

example char: https://dev.tibiadata.com/v3/character/mymsciciel

Crushed at Level 619 by Snake Riddled, Druidaneitor, Mad Dabbin, Waco Feaki, Noraxu, Savage Meche, Gerardo Mcfly, Kielbasa, Sodarock and Kimayri. Assisted by Skkrimz.

not really 😢 😂

@tobiasehlert tobiasehlert reopened this Mar 10, 2022
@tobiasehlert
Copy link
Member

Alright @3ckdasnk, I'll look into the reason field too.. thought it was only the name field that gave you issues :)

@tobiasehlert

This comment was marked as outdated.

@tobiasehlert
Copy link
Member

now it should look better @3ckdasnk. take a look at the dev URL as you mentioned :)

@tobiasehlert
Copy link
Member

@3ckdasnk released v3.1.1 with the fix and it's also active in on the api. domain :)
Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment