Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change go version in go.mod #124

Merged
merged 2 commits into from Apr 26, 2022
Merged

change go version in go.mod #124

merged 2 commits into from Apr 26, 2022

Conversation

sergot
Copy link
Contributor

@sergot sergot commented Apr 26, 2022

It looks like the project has been already migrated to 1.18 but go.mod still specifies 1.17. :)

@tobiasehlert
Copy link
Member

@sergot, had the bump on other places added in the PR #119, but let's do it separately :)

I also did go mod tidy after the bump of you plus bumped the workflows as well (7ad48e4)

@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tobiasehlert tobiasehlert added good first issue Good for newcomers dependencies Pull requests that update a dependency file labels Apr 26, 2022
@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #124 (7ad48e4) into main (07417b3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   80.59%   80.59%           
=======================================
  Files          21       21           
  Lines        2669     2669           
=======================================
  Hits         2151     2151           
  Misses        451      451           
  Partials       67       67

@tobiasehlert tobiasehlert merged commit c1c38f3 into TibiaData:main Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasehlert tobiasehlert tobiasehlert approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sergot @tobiasehlert