Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix characters with too many deaths cause crash #272

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix characters with too many deaths cause crash #272

merged 1 commit into from
Oct 9, 2023

Conversation

tobiasehlert
Copy link
Member

fix #271

@tobiasehlert tobiasehlert added bug Something isn't working go Pull requests that update Go code labels Oct 9, 2023
@tobiasehlert tobiasehlert self-assigned this Oct 9, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #272 (e22f300) into main (3602f04) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
+ Coverage   80.01%   80.02%   +0.01%     
==========================================
  Files          22       22              
  Lines        3518     3520       +2     
==========================================
+ Hits         2815     2817       +2     
  Misses        570      570              
  Partials      133      133

@tobiasehlert
Copy link
Member Author

Maybe we should add some indicator that the deaths list is truncated as well..
deaths_truncated or something maybe?

@tobiasehlert tobiasehlert mentioned this pull request Oct 9, 2023
Closed
@tobiasehlert tobiasehlert merged commit 87bb8b5 into main Oct 9, 2023
8 checks passed
@tobiasehlert tobiasehlert deleted the fix-characters-with-too-many-deaths-cause-crash branch October 9, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tobiasehlert tobiasehlert

Labels
bug Something isn't working go Pull requests that update Go code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] characters with too many deaths cause crash
1 participant
@tobiasehlert