Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance mode detection with error message return #34

Merged
merged 1 commit into from Jan 7, 2022

Conversation

tobiasehlert
Copy link
Member

This PR adds code to detect 302 Found with redirection to maintenance domain.
Clients will receive 503 Service Unavailable including an error explaining why.

@tobiasehlert tobiasehlert added enhancement New feature or request go Pull requests that update Go code labels Jan 7, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tobiasehlert tobiasehlert merged commit c02fc2e into main Jan 7, 2022
@tobiasehlert tobiasehlert deleted the maintenance-mode-detection branch January 7, 2022 10:17
tobiasehlert added a commit that referenced this pull request Jan 7, 2022
added by accident with #34
tobiasehlert added a commit that referenced this pull request Jan 7, 2022
* removing log printing
added by accident with #34

* adding trim of guild description

* using guild name based on html response
so we get correct upper and lower letters in name
@tobiasehlert tobiasehlert linked an issue Jan 12, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code
Development

Successfully merging this pull request may close these issues.

Add maintenance check in TibiadataHTMLDataCollectorV3
1 participant