Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement 404 page not found #77

Merged
merged 1 commit into from Jan 29, 2022
Merged

Conversation

phenpessoa
Copy link
Contributor

Instead of failing on non-existent endpoints, let's return a 404 instead.

@sonarcloud
Copy link

sonarcloud bot commented Jan 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #77 (707d1af) into main (62f0a57) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   80.18%   80.09%   -0.10%     
==========================================
  Files          21       21              
  Lines        2609     2612       +3     
==========================================
  Hits         2092     2092              
- Misses        446      449       +3     
  Partials       71       71              

Copy link
Member

@tobiasehlert tobiasehlert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tobiasehlert tobiasehlert merged commit cff745c into TibiaData:main Jan 29, 2022
@tobiasehlert tobiasehlert added the go Pull requests that update Go code label Jan 29, 2022
@phenpessoa phenpessoa deleted the 404 branch February 16, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Development

Successfully merging this pull request may close these issues.

None yet

2 participants