-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3 #28
Conversation
# Conflicts: # lib/SaferpayJson/Request/Request.php # phpstan.neon
You must remember we talked about automatic getter/setters. What do you think about creating a JSON schema for Saferpay API and generating our code/or automate things based on that? |
Yes, I thought about this, too. It would definitely make development simpler. It can still be added later without breaking a v3 release. |
@sprain How come that master does not contain these changes even though this PR was merged? |
I merged by accident and undid it again. I'll clean this up later. |
I see! Do unit tests excercise Saferpay sandbox? |
This is a major refactoring for version 3: