Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 #28

Merged
merged 35 commits into from
May 5, 2020
Merged

v3 #28

merged 35 commits into from
May 5, 2020

Conversation

sprain
Copy link
Contributor

@sprain sprain commented May 4, 2020

This is a major refactoring for version 3:

  • Update to most current Saferpay API version 1.17
  • Separate containers by response and request
  • Use constructors to enforce mandatory data
  • Handle Saferpay error response as exception
  • Introduce stricter handling of inheritance within classes

@sprain sprain self-assigned this May 4, 2020
@szepeviktor
Copy link
Contributor

szepeviktor commented May 4, 2020

You must remember we talked about automatic getter/setters.

What do you think about creating a JSON schema for Saferpay API and generating our code/or automate things based on that?
Although we will receive no schema from SIX: saferpay/jsonapi#20

@sprain
Copy link
Contributor Author

sprain commented May 4, 2020

What do you think about creating a JSON schema for Saferpay API and generating our code/or automate things based on that?

Yes, I thought about this, too. It would definitely make development simpler. It can still be added later without breaking a v3 release.

@sprain sprain merged commit e8c4249 into master May 5, 2020
@sprain sprain deleted the v3-wip branch May 5, 2020 07:11
@sprain sprain restored the v3-wip branch May 5, 2020 07:16
@szepeviktor
Copy link
Contributor

@sprain How come that master does not contain these changes even though this PR was merged?
https://github.com/Ticketpark/SaferpayJsonApi/commits/master

@sprain
Copy link
Contributor Author

sprain commented May 5, 2020

I merged by accident and undid it again.
I first want to try with a release candidate based on the v3-branch in my applications. See https://github.com/Ticketpark/SaferpayJsonApi/releases

I'll clean this up later.

@szepeviktor
Copy link
Contributor

I see!

Do unit tests excercise Saferpay sandbox?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants