Implement changes of Saferpay API 1.19 #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much! I will have a look at this asap. |
sprain
reviewed
May 3, 2022
| * @var string|null | ||
| * @SerializedName("Gender") | ||
| */ | ||
| private $gender; |
There was a problem hiding this comment.
Possible improvement: Add allowed gender values as class constants.
MALE, FEMALE, DIVERSE, COMPANY.
sprain
reviewed
May 3, 2022
Comment on lines
+105
to
+108
| /** | ||
| * @param bool|null $hasAccount | ||
| * @return PayerProfile | ||
| */ |
There was a problem hiding this comment.
Method docblocks can be removed everywhere as the code is self-documenting due to type hints.
|
Tests fail due coding standards. |
|
Continued in #57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added value 1.19 for SpecVersion
(Implemented)
added container PayerProfile to container RiskFactors in PaymentPage/Initialize and Transaction/Initialize requests
(Implemented for PaymentPage/Initialize, not for Transaction/Initialize that do not exist in master)
added containers Order and RiskFactors to Transaction/AlternativePayment request
(Not implemented, the request do not exist in master)
added container FraudPrevention in Transaction/Authorize, PaymentPage/Assert and Transaction/AlternativePayment responses
(Implemented for PaymentPage/Assert response, not for the others that do not exist in master)
removed parameters AccountCreationDate and PasswordLastChangeDate from container RiskFactors in PaymentPage/Initialize and Transaction/Initialize requests (moved to container PayerProfile)
(Implemented)
added parameter Description to container Payment in Saferpay Secure PayGate API CreateOffer request
(Not implemented, the request do not exist in master)
Resolves: #36