Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust alpha and beta tiddlywiki handling #1060

Closed
cdent opened this issue May 25, 2013 · 4 comments
Closed

adjust alpha and beta tiddlywiki handling #1060

cdent opened this issue May 25, 2013 · 4 comments

Comments

@cdent
Copy link
Contributor

cdent commented May 25, 2013

The current development model for tiddlywiki produces beta files and externalized beta files, but not alpha files. TiddlySpace is set up for alpha and beta, but only alpha externalized. It should switch to just beta (normal and externalized).

Is this correct @Jermolene or @ericshulman?
@ericshulman
Copy link

yes. Since we aren't actually creating alpha/beta branches in the repo, there really wasn't a true 3-stage alpha-beta-release cycle. The build scripts currently only build a pre-release "beta" target (makebeta) and a full-release target (maketw). There isn't an 'alpha' target anymore, so TiddlySpace should point to the beta target for support of pre-release changes.

@cdent
Copy link
Contributor Author

cdent commented May 30, 2013

@ericshulman I did some digging around in the visible build scripts for tiddlywiki and betas and made a bit of headway on discovering what's going on, but found some apparent inconsistencies: bldbeta points to an alpha named recipe has links that point to alpha external files:

<script type="text/javascript" src="/bags/common/tiddlers/alpha_jquery.js"></script>

Also, I was unable to determine from the tiddlywiki.github.com repo if there's an established location for an externalized release of the classic mainline release. Can there be?

Thanks.

Please let me know how I can help.

cdent added a commit that referenced this issue May 30, 2013
@cdent
Switch to beta only for "other" tiddlywiki releases
7192e01 
The current TiddlyWiki build process doesn't make alphas
at this time, so we don't want to confuse by using old
ones. This commit changes the code so it does the
right thing, but fails for the time being as the
generated externalized beta file points to the wrong files.

There are also no current test for an externalized stable
version, as that file does not yet exist (but hopefully will).

Tests associated with this process have been marked xfail,
and this is on a branch until resolution.

Part of issue #1060
@cdent
Copy link
Contributor Author

cdent commented Jun 4, 2013

Thanks to @ericshulman the necessary pieces are available, so tiddlyspace now has

  • main
  • main externalized
  • beta
  • beta externalized

@cdent cdent closed this as completed Jun 4, 2013
@pmario
Copy link
Contributor

pmario commented Jun 4, 2013

well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cdent @pmario @ericshulman