Skip to content

Commit

Permalink
Added is_* functions to do-not-vectorize list.
Browse files Browse the repository at this point in the history
Updated slurping to be compatible with older versions of Julia.
  • Loading branch information
Karandeep Singh committed Aug 22, 2023
1 parent 4125f84 commit 1ed4eac
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/TidierData.jl
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const code = Ref{Bool}(false) # output DataFrames.jl code?
const log = Ref{Bool}(false) # output tidylog output? (not yet implemented)

# Expose the global do-not-vectorize "list"
const not_vectorized = Ref{Vector{Symbol}}([:Ref, :Set, :Cols, :(:), :, :lag, :lead, :ntile, :repeat, :across, :desc, :mean, :std, :var, :median, :first, :last, :minimum, :maximum, :sum, :length, :skipmissing, :quantile, :passmissing, :cumsum, :cumprod, :accumulate, :cat_rev, :cat_relevel, :cat_infreq, :cat_lump, :cat_reorder, :cat_collapse, :cat_lump_min, :cat_lump_prop, :as_categorical])
const not_vectorized = Ref{Vector{Symbol}}([:Ref, :Set, :Cols, :(:), :, :lag, :lead, :ntile, :repeat, :across, :desc, :mean, :std, :var, :median, :first, :last, :minimum, :maximum, :sum, :length, :skipmissing, :quantile, :passmissing, :cumsum, :cumprod, :accumulate, :is_float, :is_integer, :is_string, :cat_rev, :cat_relevel, :cat_infreq, :cat_lump, :cat_reorder, :cat_collapse, :cat_lump_min, :cat_lump_prop, :as_categorical, :is_categorical])

# Includes
include("docstrings.jl")
Expand Down
6 changes: 5 additions & 1 deletion src/missings.jl
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,11 @@ macro fill_missing(df, args...)
end
end

cols..., method = args
cols = args[1:(length(args)-1)]
method = args[length(args)]

# Requires Julia 1.9
# cols..., method = args

cols_quoted = QuoteNode.(cols)

Expand Down

0 comments on commit 1ed4eac

Please sign in to comment.