Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create getProductDetails in useProduct composable #4

Closed
rohrig opened this issue Jun 15, 2023 · 2 comments
Closed

Create getProductDetails in useProduct composable #4

rohrig opened this issue Jun 15, 2023 · 2 comments
Assignees
@faizanarif121

Comments

@rohrig
Copy link
Collaborator

rohrig commented Jun 15, 2023

No description provided.

faizanarif121 added a commit to faizanarif121/nuxt3-magento-sdk-storefront that referenced this issue Jun 21, 2023
@faizanarif121
feat: add method to fetch product details TidycodeIT#4
d7ec22c
@faizanarif121 faizanarif121 mentioned this issue Jun 21, 2023
Merged
2 tasks
rohrig pushed a commit that referenced this issue Jun 21, 2023
@faizanarif121
Feature/dev product display page (#18)
8547f40 
* feat: add method to fetch product details #4

* feat: create product display page with basic ui #2

* refactor: reuse existing components
@the-lensky
Copy link

the-lensky commented Jun 22, 2023 •
edited

Guys, please don't forget to add the product video in the product query. Unfortunately, this was not done in the first version, and the query had to be overridding^^

@rohrig rohrig mentioned this issue Jun 22, 2023
Open
@rohrig
Copy link
Collaborator Author

rohrig commented Jun 22, 2023

Guys, please don't forget to add the product video in the product query. Unfortunately, this was not done in the first version, and the query had to be overridding^^

Thanks for the feedback @the-lensky 😄 I created an issue for this here

@rohrig rohrig closed this as completed Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@faizanarif121 faizanarif121

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mkozianowski @faizanarif121 @rohrig @the-lensky