Artifacts Fix: #41
Merged
Artifacts Fix: #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* include_potential. * potential_scaling. Plotting no longer occurs via nth_state().
…e now set at the beginning and end of calculations. * In gen_DEV2() renamed the D matrix to D_n to remove conflict with the D int. * Added n as a method parameter in nth_state(). * Renamed num_columns, to num_bases. * Fixed #37 with the change of the calculation of rand_index. * Added saving of 1D plots in plotting() to .png files. * Added cap on the number of states generatable so that an array indexing error doesn't occur. * Fixed mistake in stacking of all_psi.
* Still is some debugging code that will be removed in next commit... * Changed the initial psi to be random valued which aids in generating the final value. * Apply the boundary conditions = 0 for psi. * Reimplemented the infinite values fix. * Changed rand_index to sample the boundaries. * Removed old artifacts fix code. * New method generates states with arbitrary phase, added a phase correction on psi, to give it positive phase. Some general niceties: * Renamed psi -> f in boundary_conditions() to reflect it's usage for multiple array types. * In dev_mat() renamed D -> D_n to avoid confusion with the D integer. * Removed the fix_artifacts boolean from nth_state(), it happens intrinsically!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing of the artifacts issues.