fix: searching issues in payload #387
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in order to allow searching in payload
joonatanaatos
changed the title
MikaelSiidorow
approved these changes
Jun 17, 2024
| export async function up({ payload }: MigrateUpArgs): Promise<void> { | ||
| const req = {} as PayloadRequest; | ||
|
|
||
| const committeeMembers = await payload.find({ |
There was a problem hiding this comment.
Does this work without specifying a higher limit than default? I suspect there could be a limit here even with pagination false where it wouldn't apply to all items
| await payload.update({ | ||
| collection: NewsItems.slug, | ||
| id: item.id, | ||
| data: { |
There was a problem hiding this comment.
Hmm, this change for newsItems probably breaks localization in the admin UI and shows the last saved language version 🤔
It could be fine, but we could also make the field localized and save both locales here, but I wonder if that has even more implications for the search...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When merging this, make sure to run the migration from the command line into prod!
Before submitting the PR, please make sure you do the following
Formatting and linting
pnpm formatand lint the project withpnpm lint