Running TigerVNC on macOS 11 (Big Sur) just gives you empty windows.

[CendioOssman]

Describe the bug
Running TigerVNC on macOS 11 (Big Sur) just gives you empty windows.

To Reproduce
Steps to reproduce the behavior:

1. Launch TigerVNC

Expected behavior
The login window with fields and buttons visible.

Client (please complete the following information):

• OS: macOS 11 (Big Sur)
• VNC client: TigerVNC
• VNC client version: master
• Client downloaded from: Nightly build

[CendioOssman]

We got some reports here downstream and have debugged the issue:

https://www.cendio.com/bugzilla/show_bug.cgi?id=7539

It turns out to be a FLTK bug, and not a TigerVNC one. Still, we need to fix FLTK in our build systems at least.

I ended up fixing it using this patch:

diff -up fltk-1.3.5/src/Fl_cocoa.mm.gc fltk-1.3.5/src/Fl_cocoa.mm
--- fltk-1.3.5/src/Fl_cocoa.mm.gc	2020-09-02 09:22:48.283241978 +0200
+++ fltk-1.3.5/src/Fl_cocoa.mm	2020-09-02 09:23:11.162043044 +0200
@@ -3609,13 +3609,7 @@ void Fl_Window::make_current()
   } else
 #endif
   {
-    NSGraphicsContext *nsgc;
-#if MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_4
-    if (fl_mac_os_version >= 100400)
-      nsgc = [fl_window graphicsContext]; // 10.4
-    else
-#endif
-      nsgc = through_Fl_X_flush ? [NSGraphicsContext currentContext] : [NSGraphicsContext graphicsContextWithWindow:fl_window];
+    NSGraphicsContext *nsgc =   through_Fl_X_flush ? [NSGraphicsContext currentContext] : [NSGraphicsContext graphicsContextWithWindow:fl_window];
     i->gc = (CGContextRef)[nsgc graphicsPort];
   }
 

@bphinz, could you apply this on your build system for macOS? I can test the binaries for you here on our macOS 11 test box.

[bphinz]

I will update the OSX build tonight

On Wed, Sep 2, 2020 at 4:26 AM Pierre Ossman (Work account) < ***@***.***> wrote: We got some reports here downstream and have debugged the issue: https://www.cendio.com/bugzilla/show_bug.cgi?id=7539 It turns out to be a FLTK bug, and not a TigerVNC one. Still, we need to fix FLTK in our build systems at least. I ended up fixing it using this patch: diff -up fltk-1.3.5/src/Fl_cocoa.mm.gc fltk-1.3.5/src/Fl_cocoa.mm --- fltk-1.3.5/src/Fl_cocoa.mm.gc 2020-09-02 09:22:48.283241978 +0200 +++ fltk-1.3.5/src/Fl_cocoa.mm 2020-09-02 09:23:11.162043044 +0200 @@ -3609,13 +3609,7 @@ void Fl_Window::make_current() } else #endif { - NSGraphicsContext *nsgc; -#if MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_4 - if (fl_mac_os_version >= 100400) - nsgc = [fl_window graphicsContext]; // 10.4 - else -#endif - nsgc = through_Fl_X_flush ? [NSGraphicsContext currentContext] : [NSGraphicsContext graphicsContextWithWindow:fl_window]; + NSGraphicsContext *nsgc = through_Fl_X_flush ? [NSGraphicsContext currentContext] : [NSGraphicsContext graphicsContextWithWindow:fl_window]; i->gc = (CGContextRef)[nsgc graphicsPort]; } @bphinz <https://github.com/bphinz>, could you apply this on your build system for macOS? I can test the binaries for you here on our macOS 11 test box. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1087 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB45M3ICKS3W53GCIRBF553SDX6R3ANCNFSM4QSXELMA> . --

Sent from Gmail Mobile

[CendioOssman]

Did this patch make it in to the nightly build? Cause I'm unfortunately still seeing the bug. :/

[bphinz]

Oops, no. I’ll add it

On Fri, Sep 4, 2020 at 2:56 AM Pierre Ossman (Work account) < ***@***.***> wrote: Did this patch make it in to the nightly build? Cause I'm unfortunately still seeing the bug. :/ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1087 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB45M3NC3DABCWOLU56NQ6TSECFSBANCNFSM4QSXELMA> . --

Sent from Gmail Mobile

[bphinz]

The patch has been added to the build and a new nightly posted. Can you please verify?

[CendioOssman]

I've verified it works fine now. Thanks.

[bphinz]

You can download it from here: http://tigervnc.bphinz.com/nightly/

On Mon, Nov 16, 2020 at 3:14 AM jefferybond ***@***.***> wrote: I'm seeing the same issue. How do I pick up a nightly build with the fix? (bear in mind in a user, not a developer!) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1087 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB45M3JJV3WYLO2MLFPQ5V3SQDNOVANCNFSM4QSXELMA> .

-- Sent from Gmail Mobile

[EagTG]

Confirmed, nightly worked here as well fixing same problem reported initially. Thanks for the help @bphinz!!

[juniway]

my macOS is Mojave 10.14.6, and tigervnc 1.11 gives me an empty window, so I download an older version 1.8.0, and it works.