Fullscreen broken on macOS 12

[samhed]

Describe the bug
When starting a connection in fullscreen I first get the Mac title bar appearing above the vncviewer window. The vncviewer window is offset by the height of the title bar and the bottom part of the window is obscured, as seen in the first screenshot below.

My first instinct in this case was to toggle fullscreen on and off to attempt to fix it. This only made things worse.

As seen in the second screenshot below, a big part up top gets obscured instead. Additionally the mouse input gets a huge offset as well. Mouse clicks and movements appear on the remote ~300 pixels above where I actually click or move.

Note that when vncviewer has focus the offset above the window appears black, when taking the screenshot the desktop background appeared.

To Reproduce
Steps to reproduce the behavior:

1. Open vncviewer options and enable fullscreen on the monitor with the Mac application dock
2. Connect
3. See that the Mac title bar still shows and a part of the window at the bottom is obscured
4. Toggle fullscreen off using the F8 menu
5. Toggle fullscreen on
6. See that a large part at top of the vncviewer window becomes obscured
7. Get annoyed that mouse input is offset vertically

Expected behavior
I expect the fullscreen window to cover the entire monitor and the mouse input to be accurate.

Screenshots
When first connecting:

After toggling fullscreen:

Client (please complete the following information):

• OS: macOS 12.0.1
• VNC client: TigerVNC
• VNC client version: 1.12.80
• Client downloaded from: http://tigervnc.bphinz.com/nightly/

Server (please complete the following information):

• OS: Fedora 34
• VNC server: TigerVNC
• VNC server version: 1.11.0
• Server downloaded from: Fedora 34 repos
• Server was started using: /usr/bin/Xvnc :50 -SecurityTypes=None -ac -log *:stderr:100

Additional context
I see the same problems with my own builds of vncviewer. I built using both FLTK 1.3.5 and 1.3.7, the problem persists in both cases.

I can't reproduce the issue with vncviewer 1.11.0. This is likely a regression from #1282

When using only one monitor, it doesn't matter if fullscreen is enabled using "Current", "All" or "Select monitors". However, when using multiple monitors, the issue does NOT appear when using "All" or by selecting all monitors. When using multiple monitors the issue also does NOT appear when starting vncviewer in fullscreen on any of the secondary monitors. It only happens on the primary monitor that has the application dock.

[CendioOssman]

The two problems are entirely unrelated. I'll move the first one to a separate bug.

[CendioOssman]

Since the two bugs turned out to be unrelated, there was some confusion in the initial testing. The second bug is caused by the FLTK upgrade. Works fine with FLTK 1.3.5, but breaks with FLTK 1.3.7. More digging is needed to figure out what is wrong.

[CendioOssman]

Reported to FLTK in fltk/fltk#287.

@bphinz, this will also likely mean manual patching of FLTK. Once I figure out a workaround.

[CendioOssman]

@bphinz, a fix is now in place on fltk/fltk#287 so if you could have a look at adding that patch to your builds.

Should probably also include the patch on fltk/fltk#288.

[CendioOssman]

This should be the last blocker for the release, so if you could let us know when you've applied the patches @bphinz then we can put out a final 1.12 release.

[bphinz]

Sorry, I added these last night. Note that for Fltk 286 I used the patch that was backported to their 1.3 branch last week rather than the one you attached to the issue

On Thu, Nov 4, 2021 at 4:25 AM Pierre Ossman (Work account) < ***@***.***> wrote: This should be the last blocker for the release, so if you could let us know when you've applied the patches @bphinz <https://github.com/bphinz> then we can put out a final 1.12 release. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1361 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB45M3KWYRW7MLISEIYV5XLUKI7PTANCNFSM5G4KTYPA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Sent from Gmail Mobile

[CendioOssman]

@bphinz, a different fix ended up in FLTK. Could you have a look at swapping the patch to that so we're all running the same thing?

[bphinz]

I've built against fltk-6fb92e4 <fltk/fltk@6fb92e4> which looks to be what they are going to tag as v1.3.8. No patches were applied to this source.

…

On Fri, Nov 5, 2021 at 7:38 AM Pierre Ossman (Work account) < ***@***.***> wrote: @bphinz <https://github.com/bphinz>, a different fix ended up in FLTK. Could you have a look at swapping the patch to that so we're all running the same thing? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1361 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB45M3KT2GCB67HC2K2XRCLUKO6ZZANCNFSM5G4KTYPA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[CendioOssman]

I can confirm that this is now fixed in the nightly builds.