-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TigerVNC viewer should be able to open *.tigervnc files as an argument [$50 awarded] #38
Comments
Same behavior here when using IP-addresses and port like "ServerName=192.168.0.10:1". |
It supports this just fine. What it doesn't support is being given configuration files as a command line argument. It will then use the filename as the host to connect to. So this is really a feature request for opening configuration files on the command line. |
Thanks for clarification. So: When windows-double-clicking on (the associated) .tigervnc file the filename gets handed over to TigerVNC, but the content of the config file itself is not being processed. Your change of the subject is correct then. |
Correct. Besides options the viewer only supports a server name as a command line argument. |
Handling the files that your program generates isn't a feature or enhancement. That's the expected behavior. To not do that is a bug. Instead, I have to completely ignore your partially-implemented file format (because it's worthless) and write a shortcut file that passes the proper arguments to the program. If you'd actually finished implementing your file format, I could have a cross platform solution. Instead I'l have to write Windows shortcuts and .sh files that do the same thing. |
Any progress with this? I have an application that can generate .tigervnc files and which then I 'd like to open with TigerVNC in order to connect to hosts. It's not possible right now. All other VNC clients I have tried can do this, but not TigerVNC. Thanks. |
No one is working on this as far as I know. |
Not sure if it helps your use case, but the latest (1.7.80) version of the TigerVNC Java viewer has a '-config' option that can be used to specify a .tigervnc file at startup. |
@CendioOssman If that's the case that's a shame :( @bphinz Thanks for the suggestion. Unfortunately there are two issues:
|
Would you mind submitting a ticket for that. The ServerName issue I'm aware of (it's a quirk that exists because of applet mode), but I didn't know about Fullscreen. Thanks |
Mentioned in issue TigerVNC#38
This is now my favourite issue/enhancement. Being able to pass a configuration-file for the viewer launch binary is a fundamental behaviour - the alternative is wasted time loading the config file each time through a UI. The issue summary should be updated to make it clear that the request is for command-line argument support for the config file. Please vote for this issue. |
Another voice for what @javabrett said. Clicking through the GUI to load the file is functional but clunky. Being able to double-click the config file to connect would be great, but a "bookmarks" style drop menu instead of a file chooser would work too I think. |
I'd love for this to get done. |
The user can specify a tigervnc configuration file as an argument to the viewer. Previously the viewer assumed this to be a server, but now we will first check if there is any file matching the given argument. If so, try to load the content of that file, like we normally do. Fixes issue TigerVNC#38.
The user can specify a tigervnc configuration file as an argument to the viewer. Previously the viewer assumed this to be a server, but now we will first check if there is any file matching the given argument. If so, try to load the content of that file, like we normally do. Fixes issue TigerVNC#38. <<amendment 1>> The given file must use a path separator, to make sure no security issue. Make sure to catch and prompt proper permission denied errors etc. (thanks CendioOssman)
The user can specify a tigervnc configuration file as an argument to the viewer. Previously the viewer assumed this to be a server, but now we will first check if there is any file matching the given argument. If so, try to load the content of that file, like we normally do. Fixes issue TigerVNC#38. <<amendment 1>> The given file must use a path separator, to make sure no security issue. Make sure to catch and prompt proper permission denied errors etc. (Thanks CendioOssman)
The user can specify a tigervnc configuration file as an argument to the viewer. Previously the viewer assumed this to be a server, but now we will first check if there is any file matching the given argument. If so, try to load the content of that file, like we normally do. Fixes issue TigerVNC#38. <<amendment 1>> The given file must use a path separator, to make sure no security issue. Make sure to catch and prompt proper permission denied errors etc. (Thanks CendioOssman) <<amendment 2>> Look for any path separator as a first pass to classify if we are dealing with a file name or not. (Thanks CendioOssman)
The user can specify a tigervnc configuration file as an argument to the viewer. Previously the viewer assumed this to be a server, but now we will first check if there is any file matching the given argument. If so, try to load the content of that file, like we normally do. Fixes issue TigerVNC#38.
Is this still needing to be done? I saw the bounty on bountysource. |
While it has been delivered, I do not know what else has to be done in
order to close it.
…On Sun, Jul 15, 2018, 18:10 James Buren ***@***.***> wrote:
Is this still needing to be done? I saw the bounty on bountysource.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#38 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AkPaQqDdJJwe3dPgxCya0YdzP7z_ixQtks5uG2l5gaJpZM4CmB_M>
.
|
Could you please point to the related commit for this as I can't find it? Thanks |
Ah. The syntax was slightly off on the PR so github didn't automatically close this. I can do it manually. @Kypert, let me know if there are any issues claiming the bounty. |
Thanks. My understanding is that this patch has been applied to the latest beta. However, it doesn't seem to be working for me. I tried by double clicking a .tigervnc file as well as by reverting to the CLI
In both cases I get the same error:
|
Double clicking or dragging works fine for me. However the command line needs to include a Are you sure your config file just doesn't have an invalid |
OK, I checked again and CLI works the way you instructed by adding the All good now. Thanks for fixing this issue 👍 Hopefully, the next stable version which will include this patch won't take long to get released :) |
This is included in the just released 1.9.0. |
Symptom
TigerVNC viewer says
while trying to open a *.tigervnc file with ServerName given in : format.
Specifying this directly in TigerVNC viewer works as expected.
How to reproduce
Save a *.tigervnc file with port name. Example with specifics removed follows :
Now, use Windows to associate *.tigervnc files to be opened by vncviewer executable.
Try opening the file, it shows the error :
OS
Windows
Expected behaviour
When *.tigervnc file contains ServerName key in the format :, vncviewer should attempt to connect to at .
The $50 bounty on this issue has been claimed at Bountysource.
The text was updated successfully, but these errors were encountered: