Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VNCServerST::checkTimeouts calls exit(0) - does not clean up #727

Closed
astrand opened this issue Sep 25, 2018 · 1 comment
Closed

VNCServerST::checkTimeouts calls exit(0) - does not clean up #727

astrand opened this issue Sep 25, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@astrand
Copy link
Collaborator

astrand commented Sep 25, 2018

VNCServerST::checkTimeouts handles MaxDisconnectionTime, MaxConnectionTime, and MaxIdleTime. If these are reached, the server simply does exit(0). This means that destructors are not executed. For example, when using -rfbunixpath, the UNIX socket is left behind.

@CendioOssman
Copy link
Member

CendioOssman commented Sep 28, 2018

Bah. This was messy. These timeouts aren't handled like other timers, so that needs to be cleaned up first. But that in turn exposes a rather unhealthy lack of encapsulation between VNCServerST and VNCSConnectionST. So some cleanup is needed to get this in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants