Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send response for refused SetDesktopSize if the client is expecting one #1036

Merged
merged 1 commit into from
May 29, 2020

Conversation

matt335672
Copy link
Contributor

Currently, if the user sets the AcceptSetDesktopSize parameter to 0, the client receives no response at all to a SetDesktopSize message.

If the client has previously received an ExtendedDesktopSize rectangle, this not compliant with the community wiki specification.

This PR sends an ExtendedDesktopSize rectangle with (x,y) set to (1.1) "Resize is administratively prohibited" as a response to SetDesktopSize if AcceptSetDesktopSize is set to 0 and the client has previously requested the ExtendedDesktopSize pseudo-encoding.

@CendioOssman
Copy link
Member

Looks good. Thanks for finding this.

The same issue should exist for the access check just above as well. Do you think you could adjust your commit to fix them both?

@matt335672
Copy link
Contributor Author

How's that?

Let me know if you want me to squash.

Thanks for the positive response.

@CendioOssman
Copy link
Member

Nice, thanks. And yes, please squash them. And you can remove the encoding check. A client should not be sending us SetDesktopSize messages without proper support for responses.

@matt335672
Copy link
Contributor Author

Thanks for the clear guidance. Removing the encoding check makes for a more natural code flow.

@CendioOssman
Copy link
Member

Nice. Just one final code style issue; we tend to avoid {} for single line blocks. So if you can adjust that then I can merge this. :)

Sends response for SetDesktopSize as per the community wiki
specification
@matt335672
Copy link
Contributor Author

Apologies for not checking your standards - thanks for being gentle with me!

@CendioOssman
Copy link
Member

No worries. It's easy to forget. :)

Thanks for you contribution!

@CendioOssman CendioOssman merged commit bdd54b1 into TigerVNC:master May 29, 2020
@matt335672 matt335672 deleted the ack-set-desktop-size branch June 1, 2020 06:31
@samhed samhed added the bug Something isn't working label Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants