When reconnecting don't ask for login data again #1330
Conversation
|
I'm a bit cautious about this. Hanging on to passwords longer than necessary has historically been a source of security issues. An opt-in would be nice. Perhaps a check box on the dialog asking for the password? |
|
Yes, fully understand, I was also unsure about it, but just from personal use it is so convenient ;-) |
|
I think opt-in (i.e. unchecked) is the safer choice. I'm hoping we can live without the hassle of storing the choice. We don't really have any infrastructure for such things. The workflow should hopefully be |
|
So like this? Why not storing the last selection as part of the settings in the Windows registry or Linux default settings? |
|
Yes, something like that. :) The current settings storage system is based entirely around the configuration options. We currently don't have a way of storing anything other than configuration settings, and I'd like to avoid adding configuration options for "Don't ask me again" type of things as we can potentially have loads of those. So we need to build something new for those. |
vncviewer/UserDialog.cxx
Outdated
| UserDialog::UserDialog() | ||
| { | ||
| user_ = NULL; | ||
| password_ = NULL; |
There was a problem hiding this comment.
I would suggest more descriptive names on these, given that "user" and "password" occurs in multiple ways in this code.
vncviewer/UserDialog.cxx
Outdated
| *user = strDup(username->value()); | ||
| user_ = strDup(username->value()); |
There was a problem hiding this comment.
This should also be if:ed with the value of the check box.
There was a problem hiding this comment.
Why? any concerns about storing the user name in all cases?
There was a problem hiding this comment.
Should hopefully not be as sensitive as the password, but might still be some privacy aspect that people prefer this not being remembered.
I guess it's not a must to change this, but I think it might be easier to understand that it's all or nothing what the viewer remembers for credentials.
No description provided.