Various cleanups #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to do more than a simple shift to get the appropriate new value. This isn't quite as exact as a proper multiplication and division, but the error is so small it's not worth the extra cycles.
Forgot to check that we actually have a cursor from the server before trying to switch back to it after dismissing the context menu.
There were also reports of them being broken last time we still made use of them.
Get rid of unused shared MemOutStream and variable max length functionality in the ZRLE encoder.
We have no use for it, so let's keep things simple.
Reduces header dependencies.
Custom compression level and JPEG on/off are not inherent parts of the protocol negotiation so they do not belong in ConnParams. Let the UI frontend handle such things instead.
Might as well make it inline at this point as well as it is used heavily in other routines that convert entire blocks of pixels.
Make sure that the routines that convert between buffer and rgb representations follow the same algorithm so it's easier to compare them.
Zero the padding byte used when converting 24-bit RGB to 32-bit.
Consistently use the term stride rather than pitch. Also consistently represent the stride in number of pixels rather than number of bytes. There is so much code that assumes proper alignment already that we do not need the extra resolution.
It's either not used, or no longer relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of a large cleanup. This portion contains bug fixes, removal of dead code and other (hopefully) safe changes.