New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cmake TIMESTAMP function #765

Merged
merged 1 commit into from Nov 27, 2018

Conversation

Projects
None yet
2 participants
@bmwiedemann
Contributor

bmwiedemann commented Nov 18, 2018

Use cmake TIMESTAMP function
because it is not only platform independent
but also allows to override the build date
This helps to make the java timestamp file in tigervnc builds reproducible.

See https://reproducible-builds.org/ for why this is good

Also adds UTC flag, to be independent of timezone.
Also changes JAVA_DATE format to ISO-8601 date format.

Requires cmake-2.8.11+ from 2013

Use cmake TIMESTAMP function
because it is not only platform independent
but also allows to override the build date
This helps to make tigervnc builds reproducible

See https://reproducible-builds.org/ for why this is good

Also adds UTC flag, to be independent of timezone.
Also changes JAVA_DATE format to ISO-8601 date format.

Requires cmake-2.8.11+ from 2013

@bmwiedemann bmwiedemann force-pushed the bmwiedemann:timestamp branch from 7e27e52 to e27c896 Nov 18, 2018

@bphinz

This comment has been minimized.

Contributor

bphinz commented Nov 18, 2018

My only complaint is having a different CMake minimum version than the top level build requirement. Let me check the package builds for all of our supported distros and if they meet that already then I think you should adjust the PR to raise the overall minimum CMake version to 2.8.11. I won't have access to the build system until I return from holiday at the end of the week.

@bmwiedemann

This comment has been minimized.

Contributor

bmwiedemann commented Nov 19, 2018

I had already updated the PR to update the main CMake version to 2.8.11 too. Thanks for checking in the build system.

@bmwiedemann

This comment has been minimized.

Contributor

bmwiedemann commented Nov 27, 2018

ping. did you have time to look into it yet?

@bphinz

This comment has been minimized.

Contributor

bphinz commented Nov 27, 2018

Looks fine, all of the distros that we currently support supply cmake >= 2.8.12. Thanks!

@bphinz bphinz merged commit 36177f9 into TigerVNC:master Nov 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment