Use cmake TIMESTAMP function #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because it is not only platform independent but also allows to override the build date This helps to make tigervnc builds reproducible See https://reproducible-builds.org/ for why this is good Also adds UTC flag, to be independent of timezone. Also changes JAVA_DATE format to ISO-8601 date format. Requires cmake-2.8.11+ from 2013
bmwiedemann
force-pushed
the
timestamp
branch
from
7e27e52
to
e27c896
Compare
|
My only complaint is having a different CMake minimum version than the top level build requirement. Let me check the package builds for all of our supported distros and if they meet that already then I think you should adjust the PR to raise the overall minimum CMake version to 2.8.11. I won't have access to the build system until I return from holiday at the end of the week. |
|
I had already updated the PR to update the main CMake version to 2.8.11 too. Thanks for checking in the build system. |
|
ping. did you have time to look into it yet? |
|
Looks fine, all of the distros that we currently support supply cmake >= 2.8.12. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use cmake TIMESTAMP function
because it is not only platform independent
but also allows to override the build date
This helps to make the java timestamp file in tigervnc builds reproducible.
See https://reproducible-builds.org/ for why this is good
Also adds UTC flag, to be independent of timezone.
Also changes JAVA_DATE format to ISO-8601 date format.
Requires cmake-2.8.11+ from 2013