Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

antfs: Skip sending CAPABILITIES request #97

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

robho
Copy link
Contributor

@robho robho commented Nov 17, 2023

.. because no response is returned by the ANT framework for this message type, and the response is not used anyway (just logged).

Also removed some disabled code and some wrong/not so useful log messages.


Fixes #95
Fixes Tigge/antfs-cli#194

.. because no response is returned by the ANT framework for this
message type, and the response is not used anyway (just logged).

Also removed some disabled code and some wrong/not so useful log
messages.
@tuna-f1sh
Copy link
Collaborator

Thanks. For note of others: CAPABILITES can be obtained from the enum sets in Node https://github.com/Tigge/openant/blob/master/openant/easy/node.py#L62 that are grabbed during the Node.__init__()

@tuna-f1sh tuna-f1sh merged commit 5782fca into Tigge:master Nov 18, 2023
8 checks passed
@tuna-f1sh
Copy link
Collaborator

I'll make a change to drop the else in _worker_response too so it grabs the data but still pushes it to queue - like it used too. Since the current behaviour of keeping those IDs is not nice.

@robho robho deleted the antfs_no_capabilities branch November 18, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timed out while waiting for message antfs-cli fails with timeout
2 participants