Add large-scale logging based on tracing crate
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TilBlechschmidt
added
Type: Maintenance
|
Going through the code-base to add logging also resulted in a few bug-fixes 馃し |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃敡 Changes
Logging was always a bit of an afterthought and many components lacked proper log outputs with reasonable log levels. This PR is the first step to remedy this. It shifts the project away from the
logcrate in favour of thetracingcrate. At a later point, this should allow request tracing through the whole stack with proper events attached to each span. However, that comes at a later point in time 馃槈