-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI for mac and win (WIP) on Azure pipelines #107
Conversation
WIP on Windows because TileDB and TileDB-Py both build, but tests currently fail because it can't load the DLL. Probably a path/install issue, but debugging on CI isn't really efficient so I'll debug on my Windows laptop at home. |
7f8b35a
to
c5b6c63
Compare
Success on mac: https://dev.azure.com/TileDB-Inc/CI/_build/results?buildId=2 |
64f6f88
to
78c86df
Compare
Ok, Windows build and install is succeeding here, and tests are running. There are several Windows-only test failures I will have to dig into on laptop, but as far as build and CI this is just waiting on TileDB-Inc/TileDB#1125 and 1126. Once that is done I will squash the commits. https://dev.azure.com/TileDB-Inc/CI/_build/results?buildId=10 |
Hmm, the returning a different coordinate dtype error is strange on Windows, and the group comparison probably needs some Win. specific changes. Otherwise LGTM. |
- put DLLs side-by-side with the .pyd shared library - set cmake target architecture (-A) - use /MP within setup.py build - install tbb.dll
numpy/numpy#9464 🤷♂️ ... Fixed in latest commit by using
Yes: fixed by normalizing path so that the comparison succeeds (the internal path was using fwd slash). CI passed on both platforms: https://dev.azure.com/TileDB-Inc/CI/_build/results?buildId=12 |
includes and closes #97
fixes #98