Remove Unused/Extraneous Filestore.uri_import
#1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #19266: Filestore: buffer referenced before assignment. |
|
Failing windows tests due to #1218 |
ihnorton
approved these changes
Jul 22, 2022
* This function was accidentally left in; it does not work * The function to write a file located at URI to a filestore array is already correctly implemented by `Filestore.copy_from`
nguyenv
force-pushed
the
viviannguyen/sc-19266/filestore-buffer-referenced-before-assignment
branch
from
c85a8b5
to
9592bcd
Compare
nguyenv
deleted the
viviannguyen/sc-19266/filestore-buffer-referenced-before-assignment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
already correctly implemented by
Filestore.copy_from