Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pybind11 Support for Query DELETE + Tests #1309

Closed
wants to merge 15 commits into from
Closed

Pybind11 Support for Query DELETE + Tests #1309

wants to merge 15 commits into from

Conversation

ihnorton
Copy link
Member

@ihnorton ihnorton commented Aug 31, 2022

Example usage:

with tiledb.open(path, "d") as A:
    A.query(cond="attr < 4")

@nguyenv nguyenv changed the title WIP: initial delete ordering test (and temp support for pb11) [2.12] WIP: initial delete ordering test (and temp support for pb11) Sep 22, 2022
@nguyenv nguyenv changed the title [2.12] WIP: initial delete ordering test (and temp support for pb11) [2.12] Add Support for Query deletes Sep 22, 2022
@nguyenv nguyenv changed the title [2.12] Add Support for Query deletes [2.12] Add Support for Query delete Sep 22, 2022
@nguyenv nguyenv changed the title [2.12] Add Support for Query delete [2.12] Add Support for delete Mode Sep 23, 2022
@nguyenv
Copy link
Collaborator

nguyenv commented Sep 23, 2022

One thing I am unsure about with the delete API design as I have it is you need to use __getitem__ in order to actually submit the query:

with tiledb.open(path, "d", timestamp=3) as A:
    A.query(attr_cond=tiledb.QueryCondition("ints == 1"))[:]

Whereas this won't do anything and just creates a PyQuery object but would make more sense for deletes because we aren't actually getting anything back:

with tiledb.open(path, "d", timestamp=3) as A:
    A.query(attr_cond=tiledb.QueryCondition("ints == 1")

@nguyenv
Copy link
Collaborator

nguyenv commented Oct 21, 2022

One thing I am unsure about with the delete API design as I have it is you need to use __getitem__ in order to actually submit the query:

with tiledb.open(path, "d", timestamp=3) as A:
    A.query(attr_cond=tiledb.QueryCondition("ints == 1"))[:]

Whereas this won't do anything and just creates a PyQuery object but would make more sense for deletes because we aren't actually getting anything back:

with tiledb.open(path, "d", timestamp=3) as A:
    A.query(attr_cond=tiledb.QueryCondition("ints == 1")

I've modified this to make it so that the latter does do a delete without needing to apply the regular indexer.

@nguyenv nguyenv marked this pull request as ready for review October 25, 2022 00:17
@nguyenv nguyenv marked this pull request as draft October 25, 2022 02:35
@nguyenv nguyenv changed the title [2.12] Add Support for delete Mode Pybind11 Support for Query DELETE + Tests Oct 26, 2022
@ihnorton
Copy link
Member Author

ihnorton commented Nov 3, 2023

Replaced by #1388

@ihnorton ihnorton closed this Nov 3, 2023
@ihnorton ihnorton deleted the ihn/deletes branch November 3, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants