Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do Not Require Attribute in Query Condition To Be Passed to Query #1333

Merged
merged 4 commits into from Sep 28, 2022
Merged

Do Not Require Attribute in Query Condition To Be Passed to Query #1333

merged 4 commits into from Sep 28, 2022

Conversation

nguyenv
Copy link
Collaborator

@nguyenv nguyenv commented Sep 27, 2022

For example,

qc = tiledb.QueryCondition("U < 3")
u_result = A.query(attr_cond=qc, attrs=["I"])[:]

The query condition is applied to U but we no longer have to pass attrs=["U"].

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #18792: Do not require attributes passed to the QueryCondition to be set in attr.

johnkerl
johnkerl approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:rocket

tiledb/query_condition.py Outdated Show resolved Hide resolved
@nguyenv nguyenv merged commit 36e657e into dev Sep 28, 2022
@nguyenv nguyenv deleted the viviannguyen/sc-18792/do-not-require-attributes-passed-to-the-querycondition branch September 28, 2022 16:09
@gspowley gspowley mentioned this pull request Oct 11, 2022
Merged
johnkerl added a commit to single-cell-data/TileDB-SOMA that referenced this pull request Oct 12, 2022
@johnkerl
Port TileDB-Inc/TileDB-Py#1333
74ee1dc
johnkerl added a commit to single-cell-data/TileDB-SOMA that referenced this pull request Oct 12, 2022
@johnkerl
Port TileDB-Inc/TileDB-Py#1333
f0216b4
johnkerl added a commit to single-cell-data/TileDB-SOMA that referenced this pull request Oct 12, 2022
@johnkerl
Port TileDB-Inc/TileDB-Py#1333
f1de98d
johnkerl added a commit to single-cell-data/TileDB-SOMA that referenced this pull request Oct 14, 2022
@johnkerl
Port TileDB-Inc/TileDB-Py#1333
d53f719
johnkerl added a commit to single-cell-data/TileDB-SOMA that referenced this pull request Oct 14, 2022
@johnkerl
Port TileDB-Inc/TileDB-Py#1333
5b85ef3
johnkerl added a commit to single-cell-data/TileDB-SOMA that referenced this pull request Oct 15, 2022
@johnkerl
Port TileDB-Inc/TileDB-Py#1333
2d29ecc
johnkerl added a commit to single-cell-data/TileDB-SOMA that referenced this pull request Oct 17, 2022
@johnkerl
Port TileDB-Inc/TileDB-Py#1333
4a5a6db
johnkerl added a commit to single-cell-data/TileDB-SOMA that referenced this pull request Oct 19, 2022
@johnkerl
Port TileDB-Inc/TileDB-Py#1333
2704ac9
johnkerl added a commit to single-cell-data/TileDB-SOMA that referenced this pull request Oct 19, 2022
@johnkerl
Port TileDB-Inc/TileDB-Py#1333
d05de72
johnkerl added a commit to single-cell-data/TileDB-SOMA that referenced this pull request Oct 20, 2022
@johnkerl
Port TileDB-Inc/TileDB-Py#1333
5600d77
johnkerl added a commit to single-cell-data/TileDB-SOMA that referenced this pull request Oct 20, 2022
@johnkerl
Port TileDB-Inc/TileDB-Py#1333
0ca798a
johnkerl added a commit to single-cell-data/TileDB-SOMA that referenced this pull request Oct 20, 2022
@johnkerl
Port TileDB-Inc/TileDB-Py#1333
49a6312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnkerl johnkerl johnkerl approved these changes

@ihnorton ihnorton Awaiting requested review from ihnorton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nguyenv @johnkerl