Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Context and Config From Cython To Pure Python #1379

Merged
merged 24 commits into from Oct 25, 2022

Conversation

nguyenv
Copy link
Collaborator

@nguyenv nguyenv commented Oct 20, 2022

No description provided.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #15235: pybind11 wrap ctx/config.

@nguyenv nguyenv force-pushed the viviannguyen/sc-15235/pybind11-wrap-ctx-config branch from 7688cad to 7e46f06 Compare October 20, 2022 21:48
@nguyenv nguyenv force-pushed the viviannguyen/sc-15235/pybind11-wrap-ctx-config branch from 7e46f06 to f8033bf Compare October 24, 2022 22:23
@nguyenv
Copy link
Collaborator Author

nguyenv commented Oct 24, 2022

Note I have tested this against Dask, and no issues this time.

(dask-dev) vivian@mangonada:~/dask$ pytest -v --doctest-modules --ignore-glob='*/test_*.py' dask -k "diagnostics or tiledb"
================================================ test session starts ================================================
platform linux -- Python 3.9.13, pytest-7.1.3, pluggy-1.0.0 -- /home/vivian/anaconda3/envs/dask-dev/bin/python
cachedir: .pytest_cache
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/home/vivian/dask/.hypothesis/examples')
rootdir: /home/vivian/dask, configfile: setup.cfg
plugins: forked-1.4.0, hypothesis-6.56.2, rerunfailures-10.2, timeout-2.1.0, xdist-2.5.0, cov-4.0.0
collected 784 items / 778 deselected / 6 selected

dask/diagnostics/profile.py::dask.diagnostics.profile.CacheProfiler PASSED                                    [ 16%]
dask/diagnostics/profile.py::dask.diagnostics.profile.Profiler PASSED                                         [ 33%]
dask/diagnostics/profile.py::dask.diagnostics.profile.ResourceProfiler PASSED                                 [ 50%]
dask/diagnostics/profile_visualize.py::dask.diagnostics.profile_visualize.pprint_task PASSED                  [ 66%]
dask/diagnostics/progress.py::dask.diagnostics.progress.ProgressBar SKIPPED (all tests skipped by +SKIP option) [ 83%]
dask/diagnostics/progress.py::dask.diagnostics.progress.format_time SKIPPED (all tests skipped by +SKIP option) [100%]

=============================================== slowest 10 durations ================================================
1.01s call     dask/diagnostics/profile.py::dask.diagnostics.profile.ResourceProfiler
0.01s call     dask/diagnostics/profile.py::dask.diagnostics.profile.CacheProfiler
0.00s call     dask/diagnostics/profile.py::dask.diagnostics.profile.Profiler
0.00s call     dask/diagnostics/profile_visualize.py::dask.diagnostics.profile_visualize.pprint_task
0.00s setup    dask/diagnostics/profile.py::dask.diagnostics.profile.CacheProfiler
0.00s setup    dask/diagnostics/profile_visualize.py::dask.diagnostics.profile_visualize.pprint_task
0.00s setup    dask/diagnostics/progress.py::dask.diagnostics.progress.format_time
0.00s teardown dask/diagnostics/progress.py::dask.diagnostics.progress.format_time
0.00s setup    dask/diagnostics/profile.py::dask.diagnostics.profile.Profiler
0.00s setup    dask/diagnostics/progress.py::dask.diagnostics.progress.ProgressBar
============================================== short test summary info ==============================================
SKIPPED [2] ../anaconda3/envs/dask-dev/lib/python3.9/site-packages/_pytest/doctest.py:452: all tests skipped by +SKIP option
=================================== 4 passed, 2 skipped, 778 deselected in 3.36s ====================================

@nguyenv nguyenv marked this pull request as ready for review October 24, 2022 22:34
@nguyenv nguyenv requested a review from ihnorton October 24, 2022 22:34
@nguyenv nguyenv force-pushed the viviannguyen/sc-15235/pybind11-wrap-ctx-config branch from 72b700d to 974ee84 Compare October 25, 2022 14:00
…rap-ctx-config' into viviannguyen/sc-15235/pybind11-wrap-ctx-config
…rap-ctx-config' into viviannguyen/sc-15235/pybind11-wrap-ctx-config
@nguyenv nguyenv merged commit 588ed37 into dev Oct 25, 2022
@nguyenv nguyenv deleted the viviannguyen/sc-15235/pybind11-wrap-ctx-config branch October 25, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants