Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Vendored string_view Implementation #1435

Merged
merged 2 commits into from Nov 15, 2022
Merged

Remove Vendored string_view Implementation #1435

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6b1627
Remove Vendored `string_view` Implementation
nguyenv Nov 10, 2022
1bd919c
Remove `extrnal/string_view.hpp`
nguyenv Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions tiledb/core.cc
View file
Open in desktop
Expand Up @@ -29,7 +29,6 @@
#include <tiledb/tiledb_serialization.h> // C
#endif

#include "../external/string_view.hpp"
nguyenv marked this conversation as resolved.
Show resolved Hide resolved
#include "../external/tsl/robin_map.h"

#if !defined(NDEBUG)
Expand Down Expand Up @@ -1322,8 +1321,8 @@ class PyQuery {
if (!deduplicate_) {
o = py::str(data_ptr, size);
} else {
auto v = nonstd::string_view{data_ptr, size};
auto h = std::hash<nonstd::string_view>()(v);
auto v = std::string_view{data_ptr, size};
auto h = std::hash<std::string_view>()(v);
auto needle = map.find(h);
if (needle == map.end()) {
o = py::str(data_ptr, size);
Expand Down