Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.19.0 Against 2.13.0 #1487

Merged
merged 10 commits into from Dec 7, 2022
Merged

Release 0.19.0 Against 2.13.0 #1487

merged 10 commits into from Dec 7, 2022

Conversation

nguyenv
Copy link
Collaborator

@nguyenv nguyenv commented Dec 5, 2022

  • Support wheels for Python 3.11
  • DeprecationWarnings for 0.19.0 now error out. These have been changed to TileDBErrors. Error messages will be removed in two release cycles

* Support wheels for Python 3.11
* `DeprecationWarning`s for 0.19.0 now error out. These have been
  changed to `TileDBError`s. Error messages will be removed in two
  release cycles
@nguyenv
Copy link
Collaborator Author

nguyenv commented Dec 6, 2022

test_dask_multiattr_2d is hanging on POSIX with Python 3.11. Will investigate today. If I cannot figure it out by EOD then I will go ahead and release without support for 3.11 and aim to do it in the next patch release.

@nguyenv
Copy link
Collaborator Author

nguyenv commented Dec 6, 2022

Simply calling dask.distributed.Client() at all in Python 3.11 (under POSIX) yields this error:

fs = {<Nanny: None, threads: 2>, <Nanny: None, threads: 2>, <Nanny: None, threads: 2>, <Nanny: None, threads: 2>}
timeout = None, return_when = 'ALL_COMPLETED', loop = <_UnixSelectorEventLoop running=True closed=False debug=False>

    async def _wait(fs, timeout, return_when, loop):
        """Internal helper for wait().

        The fs argument must be a collection of Futures.
        """
        assert fs, 'Set of Futures is empty.'
        waiter = loop.create_future()
        timeout_handle = None
        if timeout is not None:
            timeout_handle = loop.call_later(timeout, _release_waiter, waiter)
        counter = len(fs)

        def _on_completion(f):
            nonlocal counter
            counter -= 1
            if (counter <= 0 or
                return_when == FIRST_COMPLETED or
                return_when == FIRST_EXCEPTION and (not f.cancelled() and
                                                    f.exception() is not None)):
                if timeout_handle is not None:
                    timeout_handle.cancel()
                if not waiter.done():
                    waiter.set_result(None)

        for f in fs:
>           f.add_done_callback(_on_completion)
E           AttributeError: 'Nanny' object has no attribute 'add_done_callback'

../anaconda3/envs/tiledb-3.11/lib/python3.11/asyncio/tasks.py:522: AttributeError

It is a known issue dask/distributed#6785.

@nguyenv nguyenv merged commit c6cce20 into dev Dec 7, 2022
@nguyenv nguyenv deleted the release-0.19.0 branch December 7, 2022 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants