Specify datetime format in tests #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #34107: Specify datetime Format in Tests. |
ihnorton
approved these changes
Mar 1, 2024
|
I'm going to go ahead and merge, and then rebase 1906 on top of this. |
ihnorton
deleted the
agiskounelis/sc-34107/specify-datetime-format-in-tests
branch
kounelisagis
added a commit
that referenced
this pull request
Mar 4, 2024
* Specify datetime format in tests * skip tests containing date_format argument for Python 3.7 and below --- fixes https://app.shortcut.com/tiledb-inc/story/34107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tiledb.from_csvandtiledb.from_pandasfunctions have been causing intermittent errors when running the unit tests with the message:Example failure: https://github.com/TileDB-Inc/TileDB-Py/actions/runs/7911328196/job/21595351207#step:10:1029
This is solved by explicitly passing
date_formatargument into eachfrom_{csv,pandas}call.Please note that the
date_formatargument is not available for Python 3.7 and below, so tests containing it should be skipped.